Allow excluding fields from ncdata_check - #517
Open
jimmielin wants to merge 1 commit into
Open
Conversation
…check
Adds an ordered glob-pattern exclusion list for physics_check_data rows,
so test configurations can exclude variables that hold a different
pipeline stage than the check snapshot by design (with the reason
recorded next to the patterns, e.g. in a testmod). With all expected
differences excluded, ncdata_check_err=.true. turns the check into a
hard pass/fail test.
- string_core_utils: core_glob_match ('*'-only wildcard matcher) and
core_glob_list_excluded (gitignore-style ordered first-match-wins
decision; a leading '!' keeps a matching name). Both pure; pfUnit
tests added (14 cases, passing).
- physics_data: check_field_2d/3d/4d skip rows whose report label
matches the exclusion list; patterns are stored module-side via new
set_check_field_exclusions, so the generated physics_check_data is
unchanged. Excluded rows are buffered and listed in the check output
by flush_check_field_verbose -- exclusion is never silent. Matching
is on the label a row is reported under, which for
constituent-dimensioned fields is the per-constituent file variable
name (e.g. aerochem_vmr_bc_a1).
- phys_comp: new physics_nl entry ncdata_check_exclude (char*256(200)),
broadcast and handed to physics_data; active patterns echoed at init.
- namelist_definition_cam.xml: entry with semantics and example.
jimmielin
had a problem deploying
to
CI-tests-on-CIRRUS
July 2, 2026 19:31 — with 
GitHub Actions
Error
GitHub Actions
Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
Originator(s): @jimmielin
AI tools used (if applicable; please also add the "AI-generated code" label to the PR):
What: claude-fable:5
How: Discussed the implementation, wrote most of the logic and tests.
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
.gitignore-like glob pattern fromphysics_check_data.ncdata_check_err=.true.can be turned on in tests that read multi-stage snapshots where some variables are explicitly intended to be ignored as they would not match.Describe any changes made to build system: N/A
Describe any changes made to the namelist: host-side
ncdata_check_excludeoption - default emptyList any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do: N/A
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
derecho/nvhpc/aux_sima (test is run via Github workflow. Only run the test manually if we need to save new baselines):
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: