2024 Upgrade TODOs, nice-to-haves, etc

This is intended to be a meta issue to capture any other additional issues or possible improvements that come up while upgrading, just so nothing gets lost.

TODOs

Minimum

No security warnings from dependency versions
Upgrade rubocop
Upgrade sentry

Higher priority but not mandatory

Migrate from kt-paperclip to carrierwave

Stretch goals

Upgrade to Rails 7.0
Migrate asset pipeline away from rails-assets gems to importmaps

Bugs

Nice-to-haves

Remove database cleaner per this comment
Fix admin html so that labels are properly associated with their fields (see this comment in creation specs)

Upgrade Sentry

I marked this PR a draft #914 because #914 (comment)

@esoterik

I have two questions remaining about removing paperclip. @esoterik

Partners have an attached image :logo. However the controller does not allow this here.

action-center-platform/app/controllers/admin/partners_controller.rb

Line 57 in 320e9ba

def partner_params

so its not currently working. Should I fix this or just remove the logo from the model?

TweetTarget automatically attatches a targets profile picture using the api. Does EFF have a twitter dev api account? I can migrate this but if you arent using this feature it would be better to just remove it.

Another issue I am seeing are the database migrations. this will fail after removal of the gem: https://github.com/EFForg/action-center-platform/blob/2024-upgrades-main/db/migrate/20140504080222_add_attachment_featured_image_to_action_pages.rb

looks like you can add back the helper or rewrite the migration to do the same work. Some of the columns used by paperclip arent used by carrierwave by default.

@esoterik

I have two questions remaining about removing paperclip. @esoterik

1. Partners have an attached image :logo. However the controller does not allow this here. https://github.com/EFForg/action-center-platform/blob/320e9ba37ce0d4aa05383cb986ce212b0aa6f033/app/controllers/admin/partners_controller.rb#L57

so its not currently working. Should I fix this or just remove the logo from the model?

2. TweetTarget automatically attatches a targets profile picture using the api. Does EFF have a twitter dev api account? I can migrate this but if you arent using this feature it would be better to just remove it.

We can just remove these!

Another issue I am seeing are the database migrations. this will fail after removal of the gem: https://github.com/EFForg/action-center-platform/blob/2024-upgrades-main/db/migrate/20140504080222_add_attachment_featured_image_to_action_pages.rb

looks like you can add back the helper or rewrite the migration to do the same work. Some of the columns used by paperclip arent used by carrierwave by default.

For this, I think it'd be best to rewrite the migration to do the same work.

Remove DatabaseCleaner

Ahoy has depreciation warnings in the rails 7 branch. We should upgrade it.

Will need to migrate from secrets to credentials for rails 7. I shouldnt be too bad since you mostly use env variables.

Remove DatabaseCleaner

Fix tweet targets page

Navigation Menu

Repository navigation

2024 Upgrade TODOs, nice-to-haves, etc #913

TODOs

Minimum

Higher priority but not mandatory

Stretch goals

Bugs

Nice-to-haves

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

2024 Upgrade TODOs, nice-to-haves, etc #913

Description

TODOs

Minimum

Higher priority but not mandatory

Stretch goals

Bugs

Nice-to-haves

Activity

jparr commented on Apr 10, 2024

jparr commented on Apr 17, 2024

jparr commented on Apr 17, 2024

esoterik commented on Apr 17, 2024

jparr commented on Apr 19, 2024

jparr commented on Apr 23, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions