fix(node-web-interface): use the real published octobot-client - #3659
Open
Herklos wants to merge 1 commit into
Open
fix(node-web-interface): use the real published octobot-client#3659Herklos wants to merge 1 commit into
Herklos wants to merge 1 commit into
Conversation
octobot-client@0.8.0 (and octobot-protocol@0.8.0) are now genuinely published on npm, so the file:../../../../client/octobot_client_ts workaround from the previous PR — needed only because that version didn't exist on the registry yet — is no longer needed. - package.json: octobot-client back to a plain "^0.8.0" range. - Dropped the sdk:build/prebuild/pretest scripts that built the sibling package locally before every build/test — the published tarball already ships a built dist, so there's nothing left for them to do. - package-lock.json regenerated against the real registry package (verified `npm ci` succeeds, matching what CI runs), and the now-orphaned local-path importer entry removed. Verified: npm ci, npm run build, npm test (636/636) all pass against the real dependency. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3658, now that octobot-client@0.8.0 and octobot-protocol@0.8.0 are actually published on npm.
Replaces the
file:../../../../client/octobot_client_tsworkaround (needed only because 0.8.0 wasn't on the registry yet) with a plain^0.8.0range, and drops thesdk:build/prebuild/pretestscripts that were building the sibling package locally — the published tarball already ships a builtdist, so there's nothing left for them to do.Verified:
npm ci,npm run build,npm test(636/636) all pass against the real dependency.🤖 Generated with Claude Code