[Sync] Migrate signals to product events - #3657
Merged
Merged
Conversation
Herklos
force-pushed
the
fix/signal-publish
branch
7 times, most recently
from
August 25, 2026 08:06
1879b42 to
db0330d
Compare
Herklos
marked this pull request as ready for review
August 25, 2026 08:07
Member
There was a problem hiding this comment.
👍 can we move this file to the functional_tests dir plz ? (it's not a unit tests file)
Comment on lines
+149
to
+160
| try: | ||
| result = await session.content_client.pull(layout.keyring_pull(space_id)) | ||
| except starfish_sdk.types.StarfishHttpError: | ||
| return None | ||
| keyring = starfish_keyring.Keyring.from_dict(result.data) | ||
| try: | ||
| return starfish_keyring.create_keyring_encryptor( | ||
| keyring, session.keys["kemPub"], session.keys["kemPriv"], trusted_adders=trusted_adders | ||
| ) | ||
| except ValueError as encryptor_error: | ||
| _logger().debug(f"Could not build the artifact keyring encryptor: {encryptor_error}") | ||
| return None |
Member
There was a problem hiding this comment.
is it ok here to silence those exceptions?
Comment on lines
+209
to
+212
| _logger().debug( | ||
| f"Could not open artifact keyring for space {space_id!r}: {encryptor_error}" | ||
| ) | ||
| return [] |
Member
There was a problem hiding this comment.
same here, should we just log debug and continue instead of leaving it to the caller to chose to raise or not?
| _get_identity(context) | ||
| ) | ||
| plaintext = debug_state.to_json() | ||
| case enums.TemporaryCollections.TEMP_PRODUCT_SIGNALS.value: |
Herklos
force-pushed
the
fix/signal-publish
branch
from
August 25, 2026 12:18
db0330d to
d0d5b13
Compare
Contributor
Author
|
it's up |
GuillaumeDSM
approved these changes
Aug 26, 2026
Comment on lines
+154
to
+155
| if pull_error.status == 404: | ||
| return None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.