Skip to content

Add template: peach.build.hosting#1339

Open
grega91 wants to merge 2 commits into
Domain-Connect:masterfrom
grega91:master
Open

Add template: peach.build.hosting#1339
grega91 wants to merge 2 commits into
Domain-Connect:masterfrom
grega91:master

Conversation

@grega91

@grega91 grega91 commented Jul 7, 2026

Copy link
Copy Markdown

Description

New template for Peach (peach.build), a 3D web-experience builder. A single static
CNAME points the customer's www host at our Cloudflare-for-SaaS endpoint
(domains.peach.build); TLS certificates are issued automatically on our side.
The service is live; discovery and the sync apply flow are implemented per spec.

Type of change

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

  • syncPubKeyDomain is set — justification for omission: the template contains no
    variables and a single static CNAME record pointing at the provider's fixed customer
    endpoint. Applying it is byte-identical to creating the same public record manually, it
    grants no access on the Peach side (attaching a domain to content additionally requires
    authenticated ownership of that content in our platform, verified independently of DNS),
    and no user data flows through the apply URL. We're happy to add signed requests in a
    follow-up version if preferred.
  • warnPhishing is not set alongside syncPubKeyDomain
  • syncRedirectDomain is set whenever the template uses redirect_uri in the synchronous flow (N/A — redirect_uri not used)
  • no TXT record contains SPF content (no TXT records in this template)
  • txtConflictMatchingMode is set on every TXT record that must be unique (N/A — no TXT records)
  • no variable is used as a bare full record value (N/A — no variables)
  • no bare variable is used as the full host label (N/A — no variables)
  • no variable is used in the host field to create a subdomain (N/A — no variables)
  • %host% does not appear explicitly in any host attribute
  • essential is set to OnApply on records the end user may need to modify or remove without breaking the template (N/A — the single CNAME is the service; removing it is intentional disconnection)

Online Editor test results

Editor test link(s):
Test peach.build/hosting example.com/@

Test peach.build/hosting example.com/shop

@github-actions github-actions Bot added no syncPubKeyDomain syncPubKeyDomain not set. Template is not secured. Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

JSON Filename Check Passed

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

JSON Schema Validation Passed

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Linter OK

peach.build.hosting.json

Level Code Note
info DCTL1029 template does not have syncPubKeyDomain

@github-actions github-actions Bot removed Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

PR Description Check Passed

All required sections are filled in correctly.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 9/10 checkboxes ticked
  OK  Online Editor test results: 2 link(s) found
  OK  Template coverage: all 1 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

Comment thread peach.build.hosting.json
"version": 1,
"logoUrl": "https://www.peach.build/peach-logo.svg",
"description": "Connects your domain to your published Peach experience (www CNAME to Peach's edge; SSL is issued automatically).",
"variableDescription": "No variables — the record targets Peach's fixed customer CNAME endpoint.",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-consider using syncPubKeyDomain.
Yes, the template has no variables but still some providers require it by policy and the templates need to be updated.

@github-actions github-actions Bot added the review issues Changes requested from PR review label Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no syncPubKeyDomain syncPubKeyDomain not set. Template is not secured. review issues Changes requested from PR review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants