chore(openapi): regenerate the spec and clients for the target connection options - #1898
Open
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 2 commits into
Conversation
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
chore/regenerate-openapi-provisioning
branch
from
July 29, 2026 21:31
761ebc0 to
bcc5c93
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
chore/regenerate-openapi-provisioning
branch
from
July 30, 2026 02:49
bcc5c93 to
0aed3f2
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
chore/regenerate-openapi-provisioning
branch
2 times, most recently
from
July 30, 2026 03:05
5b3da88 to
42d3873
Compare
…tion options Mechanical output of `tools/generate-openapi/generate.ps1` then `devolutions-gateway/openapi/generate_clients.ps1`, with the pinned 7.9.0 generator.
Hand-maintained OpenAPI shapes for the dual-op preflight API. Generated yaml/clients already include the same surface.
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
chore/regenerate-openapi-provisioning
branch
from
July 30, 2026 14:55
42d3873 to
235a694
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
marked this pull request as ready for review
July 30, 2026 15:44
Copilot started reviewing on behalf of
irvingouj@Devolutions (irvingoujAtDevolution)
July 30, 2026 15:45
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Regenerates the OpenAPI specification and clients to expose target connection options during preflight provisioning.
Changes:
- Adds
provision-connection-optionsand Kerberos KDC options. - Regenerates TypeScript and .NET client models.
- Updates generated API documentation and manifests.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
devolutions-gateway/src/openapi.rs |
Defines the new OpenAPI models and operation kind. |
devolutions-gateway/openapi/gateway-api.yaml |
Adds the generated schemas. |
devolutions-gateway/openapi/ts-angular-client/model/targetConnectionOptions.ts |
Adds the TypeScript options model. |
devolutions-gateway/openapi/ts-angular-client/model/preflightOperationKind.ts |
Adds the operation kind. |
devolutions-gateway/openapi/ts-angular-client/model/preflightOperation.ts |
Exposes connection options. |
devolutions-gateway/openapi/ts-angular-client/model/models.ts |
Exports the new model. |
devolutions-gateway/openapi/ts-angular-client/.openapi-generator/FILES |
Tracks the generated model. |
devolutions-gateway/openapi/dotnet-client/src/Devolutions.Gateway.Client/Model/TargetConnectionOptions.cs |
Adds the .NET options model. |
devolutions-gateway/openapi/dotnet-client/src/Devolutions.Gateway.Client/Model/PreflightOperationKind.cs |
Adds the .NET enum member. |
devolutions-gateway/openapi/dotnet-client/src/Devolutions.Gateway.Client/Model/PreflightOperation.cs |
Exposes connection options. |
devolutions-gateway/openapi/dotnet-client/README.md |
Lists the new model. |
devolutions-gateway/openapi/dotnet-client/docs/TargetConnectionOptions.md |
Documents the options model. |
devolutions-gateway/openapi/dotnet-client/docs/PreflightOperation.md |
Documents the new property. |
devolutions-gateway/openapi/dotnet-client/.openapi-generator/FILES |
Tracks generated .NET files. |
devolutions-gateway/openapi/doc/index.adoc |
Updates generated API documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+425
to
+426
| #[serde(rename = "provision-connection-options")] | ||
| ProvisionConnectionOptions, |
Comment on lines
+405
to
+408
| /// Kerberos KDC address for the target-side CredSSP connection. | ||
| /// | ||
| /// Supported schemes are `tcp` and `udp`. | ||
| krb_kdc: Option<String>, |
| PreflightOperationKind, | ||
| AppCredential, | ||
| AppCredentialKind, | ||
| TargetConnectionOptions, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just generate openapi, updated openapi .rs source file to stay consistent