fix(agent): treat domain auto-detection as a fallback - #1886
Draft
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
Draft
fix(agent): treat domain auto-detection as a fallback#1886irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
Conversation
Auto-detection ran in addition to whatever advertise_domains was configured, and the duplicate check compared whole strings, so a parent domain was never seen as already covered. Configuring machine.example.com on a host joined to example.com advertised both. That is a silent widening: domains match by suffix, so machine.example.com is one host and its subdomains while example.com is every host in the domain at any depth. The agent ended up claiming routes nobody asked for. Only auto-detect when advertise_domains is empty. Configurations that rely on auto-detection alone are unaffected.
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
fix/agent-tunnel-auto-detect-fallback
branch
from
July 29, 2026 16:04
1d8077a to
db2ab04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP