Implement WinUI-style immersive overlays and migrate existing pop-ups; tweak context menus to better match WinUI styling; implement sliding pill animation - #5194
Conversation
28289a6 to
176c869
Compare
e458f67 to
176c869
Compare
|
Gabriel Dufresne (@GabrielDuf) Hi! Could you take a look at this when you get time? Thanks! |
|
Hi, Before I can properly review this, would it be possible to make the branch available in a way that I can check out locally? I'm able to view the PR and your fork on GitHub, but I haven't been able to clone or check out the branch to test the changes, as I get an "Access denied" error. Also, while I don't mind the underlying fixes, I'd prefer to keep the current layout of the operation/package details panel. I understand the goal is to make it look more like WinUI, but the current layout was intentionally designed to resemble the UI that existed before the migration to Avalonia, and I'd like to preserve that. I don't mind keeping the immersive dialogs; it's mainly the changes to the rest of the layout that I'd prefer to avoid. I'd appreciate it if you could keep the existing layout and limit this PR to the functional changes. If you'd like to propose a redesign of this view, I'd be happy to discuss it in a separate PR. |
I'm not sure about the access issue you mentioned. My fork repository should be public and checking out shouldn't be an issue. I'll look into it in a bit. For issue 2 specifically: keeping it pixel-perfect to the previous UI is also my goal as well. I had the original WinUI version open side-by-side during testing, and the effect is very similar to the one I implemented. You can find my own debug builds here: |
Hi, I checked the repository and the branch is public and still available. I suspect the checkout problem may be caused by the PR branch being named main, since that can conflict with the existing local main branch. You should be able to check out the PR without accessing my fork directly using GitHub’s PR ref: git fetch origin refs/pull/5194/head:pr-5194 Please let me know the full command and error output if this still fails. |
|
Hi Meteoni-San (@Meteony), I took a look at the PR, and the dialog migration itself looks great. There are two things that need to be addressed before this can be merged:
Other than those two points, everything else looks good. Thanks! |

Replaces pop-up windows with same-window immersive dialogs styled after WinUI.
The PR also:
Closes: #5189, #5191, #5177