Skip to content

fix(similarity): skip empty fingerprint sort #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WarGloom wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

fix(similarity): skip empty fingerprint sort #1368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5178cde
fix(similarity): skip empty fingerprint sort
WarGloom Jul 30, 2026
28fc4e2
Merge branch 'main' into agent/fix-empty-similarity-sort
WarGloom Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/pipeline/pass_similarity.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,12 @@ static int collect_fp_entries(cbm_gbuf_t *gbuf, fp_entry_t **out_entries) {
};
}
}
/* Canonicalize (determinism) — see cmp_fp_entry_by_qn. */
qsort(entries, (size_t)count, sizeof(fp_entry_t), cmp_fp_entry_by_qn);
/* Canonicalize (determinism) — see cmp_fp_entry_by_qn. Avoid passing the
* NULL empty-set buffer to qsort: libc treats zero elements as a no-op,
* but the standard function contract still requires a valid base pointer. */
if (count > 1) {
qsort(entries, (size_t)count, sizeof(fp_entry_t), cmp_fp_entry_by_qn);
}
*out_entries = entries;
return count;
}
Expand Down
Loading