chore: remove local soak/memlab run output committed to main - #1352
Merged
Conversation
13 soak directories and 4 memlab files -- 78 files of daemon logs, latency and metrics CSVs, and summaries -- were committed to the repository root in 7808eee ("revert(daemon): drop the connection thread pool"). They are local run output from manual soak legs: no source, no tests, nothing anyone needs from a clone, and they sit in the root listing above scripts/ where they are the first thing a visitor sees. Untracked, not deleted: every file is preserved locally under private/ (already gitignored), so the measurements remain available for comparison without being part of the published tree. .gitignore is widened so this cannot recur. It already carried `soak-results/` and `soak-results-query-leak/`, but every directory that actually landed was hand-named for its run -- soak-mac2, soak-ql-mac, soak30-linux -- so none of them matched. The new patterns are ROOT-ANCHORED (`/soak*/`, `/memlab-*`) rather than bare globs, verified so scripts/soak-legs.sh, scripts/soak-test.sh and tests/test_soak_daemon_recovery_contract.sh stay tracked; only run directories at the repo root are caught. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
13 soak directories and 4
memlab-*files — 78 files of daemon logs, latency/metrics CSVs and summaries — were committed to the repository root in7808eee("revert(daemon): drop the connection thread pool"). They're local run output from manual soak legs: no source, no tests, nothing a clone needs, and they sit in the root listing abovescripts/, so they're among the first things a visitor sees.Untracked, not deleted
Every file is preserved locally under
private/(already gitignored), so the measurements stay available for comparison without being part of the published tree.Why it recurred, and the fix
.gitignorealready carriedsoak-results/andsoak-results-query-leak/— but every directory that actually landed was hand-named for its run (soak-mac2,soak-ql-mac,soak30-linux), so none matched.New patterns are root-anchored rather than bare globs:
Verified both directions:
scripts/soak-legs.sh,scripts/soak-test.shandtests/test_soak_daemon_recovery_contract.shremain tracked (git check-ignorereturns nothing for them), while a recreatedsoak-mac2/x.logandmemlab-mac.logare now correctly ignored.Diff
79 files changed, 7 insertions(+), 14687 deletions(-)— the 7 insertions are the .gitignore comment and patterns.