Skip to content

fix: improve editor UI #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitonsky merged 22 commits into from
Jul 12, 2026
Merged

fix: improve editor UI #347

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d42d60d
fix: link color
vitonsky Jul 6, 2026
1213fd8
fix: css custom props name
vitonsky Jul 6, 2026
19539a2
fix: consistent selection style
vitonsky Jul 6, 2026
719e55f
chore: update packages
vitonsky Jul 7, 2026
80da843
chore: improve CSS
vitonsky Jul 7, 2026
1d496c6
chore: update imports
vitonsky Jul 7, 2026
cbd5660
test: implement Playwright unit tests
vitonsky Jul 7, 2026
10ee5c4
test: add text with few paragraphs
vitonsky Jul 7, 2026
5f52f6e
chore: update tsconfig types
vitonsky Jul 8, 2026
acbecca
test: preserve empty paragraphs
vitonsky Jul 8, 2026
d629334
feat: ensure empty paragraph in Lexical
vitonsky Jul 8, 2026
eae00e5
feat: convert each 2 lines into 1 paragraph
vitonsky Jul 8, 2026
e0fd1e0
feat: serialize empty paragraph as empty line
vitonsky Jul 8, 2026
bc00410
fix: stabilize empty lines strategy
vitonsky Jul 11, 2026
a9395e7
test: fix dom test
vitonsky Jul 11, 2026
3e573fc
test: update serialization cases
vitonsky Jul 11, 2026
e79bec4
chore: fix list styles
vitonsky Jul 12, 2026
436558d
ci: install playwright
vitonsky Jul 12, 2026
d403848
fix: header styles
vitonsky Jul 12, 2026
57787e1
docs: add readme
vitonsky Jul 12, 2026
96f8f18
ci: build the app
vitonsky Jul 12, 2026
995e814
ci: build the app
vitonsky Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions packages/app/src/components/theme/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,7 @@
============================================================
*/
/* eslint-disable @cspell/spellchecker */
import {
defineConfig,
defineRecipe,
defineSlotRecipe,
SystemStyleObject,
} from '@chakra-ui/react';
import { defineConfig, defineRecipe, defineSlotRecipe } from '@chakra-ui/react';
import {
alertAnatomy,
dialogAnatomy,
Expand Down Expand Up @@ -82,6 +77,13 @@ export const getScrollBarStyles = (): Record<string, any> => {

export default defineConfig({
globalCss: {
html: {
'& *::selection': {
color: 'selection.foreground',
backgroundColor: 'selection.background',
},
},

body: {
margin: 0,
backgroundColor: 'var(--chakra-colors-surface-background)',
Expand All @@ -97,12 +99,6 @@ export default defineConfig({
'Segoe UI Emoji'`,
},

':root': {
'::selection': {
color: 'selection.foreground',
backgroundColor: 'selection.background',
},
} as SystemStyleObject,
...getScrollBarStyles(),
},

Expand Down
6 changes: 3 additions & 3 deletions packages/app/src/features/NoteEditor/RichEditor/theme/RichEditor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@

.RichEditor__textCode {
background-color: var(--chakra-colors-dim-100);
color: var(--chakra-colors-typography-base);
color: var(--chakra-colors-typography);
Comment thread
vitonsky marked this conversation as resolved.
padding: 1px 0.25rem;
font-family: Menlo, Consolas, Monaco, monospace;
font-size: 94%;
Expand All @@ -115,7 +115,7 @@

.RichEditor__link {
display: inline-block;
color: var(--chakra-colors-link-base);
color: var(--chakra-colors-link);
text-decoration: inherit;
}

Expand All @@ -129,7 +129,7 @@
--block-padding: 0.8rem;

background-color: var(--chakra-colors-dim-100);
color: var(--chakra-colors-typography-base);
color: var(--chakra-colors-typography);
font-family: Menlo, Consolas, Monaco, monospace;
display: block;
padding: var(--block-padding);
Expand Down