Use an error constant for "nil client" errors - #90
Merged
Conversation
This should allow tests and other code that relied on some predictable behavior on nil client usage to still receive that behavior: Instead of `nil`, we just return ErrNoClient now.
arbll
reviewed
May 29, 2019
arbll
left a comment
arbll
left a comment
Member
There was a problem hiding this comment.
Those changes look perfectly reasonable to me. Just a small nitpick and we should be good to merge. Sorry for the breaking change, I didn't realize this could be used as a feature. Thanks for the PR!
* Incr, Decr * Timing, TimeInMilliseconds
By using assertNotPanics in the test case, we can assert that it doesn't panic just as well, and it doesn't require maintaining the same list of function calls in two tests.
Contributor
Author
|
Updated! PTAL, @arbll (: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the error behavior for nil clients to be a bit more consistent:
nilclient is used (from the freshly-allocated errors in Don't ignore nil clients #65)statsdclient that isnilAs mentioned in #65, this is affecting us in stripe/veneur#722; hope you all agree that this change will work.