Skip to content

Fix nil pointer dereference in Windows pipe writer Close #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 3 commits into from
Aug 14, 2026
Merged

Fix nil pointer dereference in Windows pipe writer Close #397

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f00202
Fix nil pointer dereference in Windows pipe writer Close
mrafi97 Aug 14, 2026
17ebff1
Update statsd/pipe_windows.go
mrafi97 Aug 14, 2026
c3f1f6e
Remove trailing whitespace in pipe_windows.go Close
mrafi97 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion statsd/pipe_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,14 @@ func (p *pipeWriter) ensureConnection() (net.Conn, error) {
}

func (p *pipeWriter) Close() error {
return p.conn.Close()
p.mu.RLock()
conn := p.conn
p.mu.RUnlock()
// conn is nil if no write ever established a connection
if conn != nil {
return conn.Close()
}
return nil
Comment thread
mrafi97 marked this conversation as resolved.
Outdated
}

// GetTransportName returns the name of the transport
Expand Down
13 changes: 13 additions & 0 deletions statsd/pipe_windows_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,19 @@ func TestPipeWriterEnv(t *testing.T) {
assert.Equal(t, got, "metric:1|g|#key:val\n")
}

// TestPipeWriterCloseWithoutWrite ensures closing a writer that never
// established a connection does not panic. newWindowsPipeWriter defers
// connecting to the first write, so conn is nil until then.
func TestPipeWriterCloseWithoutWrite(t *testing.T) {
pipepath, f, _ := createNamedPipe(t)
defer os.Remove(f.Name())

w, err := newWindowsPipeWriter(pipepath, defaultWriteTimeout)
require.Nil(t, err)

assert.Nil(t, w.Close())
}

func TestPipeWriterReconnect(t *testing.T) {
pipepath, f, ln := createNamedPipe(t)
defer os.Remove(f.Name())
Expand Down
Loading