Skip to content

[DT-3774] Filter Manage DAC table dataset count by dacApproval #3713

Merged
kevinmarete merged 4 commits into
developfrom
km-dt-3774-fix-dataset-counts
Jul 6, 2026
Merged

[DT-3774] Filter Manage DAC table dataset count by dacApproval #3713
kevinmarete merged 4 commits into
developfrom
km-dt-3774-fix-dataset-counts

Conversation

@kevinmarete

@kevinmarete kevinmarete commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DT-3774

Summary

The Manage DAC table's dataset count included all datasets regardless of approval status, while the DAC profile/EditDac page only counts approved ones. Filtered datasetsCellData to dacApproval === true so both views agree. Depends on the companion consent fix that populates dacApproval on GET /api/dac.

Backend PR: DataBiosphere/consent#2962

Before
Before-Table

After
After-Table

Approved Datasets
Approved-Datasets


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@kevinmarete kevinmarete self-assigned this Jul 3, 2026
@kevinmarete kevinmarete changed the title fix: filter by dac approval [DT-3774] Fix missing dac_approval column in DacDAO.findAll() Jul 3, 2026
@kevinmarete kevinmarete changed the title [DT-3774] Fix missing dac_approval column in DacDAO.findAll() [DT-3774] Filter Manage DAC table dataset count by dacApproval Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Coverage Report for DUOS Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 64.72% 6152 / 9505
🔵 Statements 64.19% 6479 / 10093
🔵 Functions 57.72% 1642 / 2845
🔵 Branches 53.25% 3445 / 6470
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/manage_dac_table/ManageDacTableCellData.tsx 100% 94.11% 100% 100%
Generated in workflow #6151 for commit a9ca00f by the Vitest Coverage Report Action

@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

@kevinmarete kevinmarete marked this pull request as ready for review July 3, 2026 20:23
@kevinmarete kevinmarete requested a review from a team as a code owner July 3, 2026 20:23
@kevinmarete kevinmarete requested review from fboulnois and rushtong and removed request for a team July 3, 2026 20:23

@fboulnois fboulnois left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rushtong rushtong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@kevinmarete kevinmarete merged commit b85eced into develop Jul 6, 2026
12 checks passed
@kevinmarete kevinmarete deleted the km-dt-3774-fix-dataset-counts branch July 6, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants