[DT-3774] Fix missing dac_approval column in DacDAO.findAll() #2962
Merged
Conversation
kevinmarete
changed the title
dac_approval column in DacDAO.findAll()
kevinmarete
requested review from
Copilot,
fboulnois and
rushtong
and removed request for
a team
rushtong
approved these changes
Jul 6, 2026
rushtong
left a comment
rushtong
left a comment
Contributor
There was a problem hiding this comment.
Nice catch, minor suggested improvement inline.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-3774
Summary
GET /api/dacnever selecteddac_approvalfor the datasets embedded in each DAC, sodacApprovalwas alwaysnullon that response — causing the Manage DAC table's dataset counts to disagree with the DAC profile page (which uses a different endpoint that does select this column). Added the column to the query and mapped it inDacReducer, added aDac.getDatasets()accessor, and added a DAO test covering approved vs. pending datasets.Have you read CONTRIBUTING.md lately? If not, do that first.