fix(agents): make the codex timeout wrapper zsh-safe - #19
Closed
anderson-spider wants to merge 1 commit into
Closed
Conversation
`${T:+$T 600}` relies on bash word-splitting; under zsh (Claude Code's
shell on macOS) it reaches execve as one argv word and every lane run
dies with "no such file or directory". Build the prefix as positional
parameters and probe the timeout binary by running it. Split the EFFORT
override the same way so each expansion is exactly one argv word.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
Both implementer lanes told the agent to invoke codex as:
${T:+$T 600}relies on bash word-splitting an unquoted parameter expansion. zsh does not split by default, and Claude Code's Bash tool runs zsh on macOS, so the prefix reachesexecveas one argv word and the run dies before codex starts:Every invocation of
codex-implementerandsol-implementerfailed on such machines. Because the failure surfaces as a missing binary, it is easy to misread as a codex install/auth problem. Same root cause as #12 and #17.The fix
if [ -n "$T" ]; then set -- "$T" 600; else set --; fithen"$@" codex exec."$@"expands to zero words when nothing is set — in bash, zsh and sh — so the uncapped fallback needs no special-casing."$c" 1 true) instead of trustingcommand -v, which still returns a hit for a stale hash-cache entry or a dangling symlink.${EFFORT:+-c model_reasoning_effort=$EFFORT}is also a single word under zsh. Split into${EFFORT:+-c} ${EFFORT:+model_reasoning_effort=$EFFORT}so each expansion yields exactly one argv word or vanishes. On codex-cli 0.153.0 the override still applied because codex trims the key, so this is hardening against an undocumented behaviour, not a live effort-misrouting bug.Docs-only; no behavioural change on bash.
Verification
Extracted the new snippet into a script and ran it on macOS (coreutils
gtimeoutinstalled):gtimeout, two clean argv words, exit 0PATH=/usr/bin:/bin(no timeout binary)exit 127)${EFFORT:+-c} ${EFFORT:+…}under zshclaude plugin validate .passes.