-
Notifications
You must be signed in to change notification settings - Fork 188
Feature: optionally preserve blank lines between struct fields #1657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
giuinktse7
wants to merge
6
commits into
DanielGavin:master
Choose a base branch
from
giuinktse7:feat/preserve-struct-blank-lines
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7ef1437
feat: add preserve_struct_blank_lines to odinfmt
giuinktse7 ccff221
chore(test): add tests for preserve_struct_blank_lines
giuinktse7 157cf11
chore(docs): update README & JSONschema for preserve_struct_blank_lines
giuinktse7 dab8f38
feat: use section-scoped struct field alignment across blank lines
giuinktse7 807be2d
chore(test): update tests for preserve_struct_blank_lines
giuinktse7 1580cff
Merge branch 'DanielGavin:master' into feat/preserve-struct-blank-lines
giuinktse7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
tools/odinfmt/tests/collapse_struct_field_blank_lines/.snapshots/structs.odin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package collapse_struct_field_blank_lines | ||
|
|
||
| Pair :: struct { | ||
| first: int, | ||
| second: int, | ||
| } |
7 changes: 7 additions & 0 deletions
7
tools/odinfmt/tests/collapse_struct_field_blank_lines/structs.odin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package collapse_struct_field_blank_lines | ||
|
|
||
| Pair :: struct { | ||
| first: int, | ||
|
|
||
| second: int, | ||
| } |
27 changes: 27 additions & 0 deletions
27
tools/odinfmt/tests/preserve_struct_field_blank_lines/.snapshots/structs.odin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package preserve_struct_field_blank_lines | ||
|
|
||
| Settings :: struct { | ||
| window_width: int, | ||
| window_height: int, | ||
| target_fps: int, | ||
|
|
||
| fullscreen: bool, | ||
| vertical_sync: bool, | ||
| } | ||
|
|
||
| With_Comments :: struct { | ||
| first: int, // trailing comment | ||
|
|
||
| // The second group. | ||
| second: int, | ||
|
|
||
| // The third group follows this comment without a blank line. | ||
| third: int, | ||
| } | ||
|
|
||
| Capped_By_Newline_Limit :: struct { | ||
| first: int, | ||
|
|
||
|
|
||
| second: int, | ||
| } | ||
4 changes: 4 additions & 0 deletions
4
tools/odinfmt/tests/preserve_struct_field_blank_lines/odinfmt.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "newline_limit": 2, | ||
| "preserve_struct_blank_lines": true | ||
| } |
29 changes: 29 additions & 0 deletions
29
tools/odinfmt/tests/preserve_struct_field_blank_lines/structs.odin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package preserve_struct_field_blank_lines | ||
|
|
||
| Settings :: struct { | ||
| window_width: int, | ||
| window_height: int, | ||
| target_fps: int, | ||
|
|
||
| fullscreen: bool, | ||
| vertical_sync: bool, | ||
| } | ||
|
|
||
| With_Comments :: struct { | ||
| first: int, // trailing comment | ||
|
|
||
| // The second group. | ||
| second: int, | ||
|
|
||
| // The third group follows this comment without a blank line. | ||
| third: int, | ||
| } | ||
|
|
||
| Capped_By_Newline_Limit :: struct { | ||
| first: int, | ||
|
|
||
|
|
||
|
|
||
|
|
||
| second: int, | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder with this if we should align each section separately? Similarly to how
gofmthandles it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I agree! That behavior is better.
I've updated the PR (& PR body) to use the
gofmtstyle, see: