Align constant definitions in nested blocks - #1651
Merged
BradLewis merged 1 commit intoSep 1, 2026
Merged
Conversation
Compute constant alignment for each Block_Stmt so declarations inside procedures, conditionals, when statements, and loops are aligned.
BradLewis
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setting
align_constant_definitionscurrently only applies to file-level declarations. Constants inside procedures and nested control-flow blocks remain unaligned.Note: I may be misunderstanding the intended behavior, but I found the current behavior surprising and believe this is a feature gap. You can just close this PR if the current behavior is intentional.
Cause
The constant alignment map is populated for
file.decls, but nested statement lists are not scanned before formatting:Fix
Compute constant alignment in the
Block_Stmtvisitor before callingvisit_block_stmts.All braced bodies ultimately pass through this visitor, so the option now applies consistently inside procedures,
if,when, and loop blocks:Verification
Added snapshot coverage for constants inside:
ifblockswhenblocksThe complete
odinfmtsnapshot suite passes.