Added logic to the dunedaq_integtest_bundle.sh script to provide hints…

[bieryAtFnal]

…to the user when no tests are left after filtering based on the command-line options.

Description

In recent discussions, it was mentioned that there are times that the daqsystemtest/dunedaq_integtest_bundle.sh script finds no integtests that match what the user requested based on the command-line options provided to the script, and it is not obvious why the bundle script doesn't run any tests.

In subsequent discussions of how to deal with this issue, one suggestion was to provide more information to the user about what had happened and suggest alternatives (as compared with adding logic to the script to guess what the user wanted).

This PR attempts to do that. It now provides suggested command-line options.

For example:

$ dunedaq_integtest_bundle.sh -k process

Integtests from the _daqsystemtest_ repo will be run...
...Looking for integtests...

*** No integtests were found that matched the specified command-line options.

*** Consider adding '-r drunc' to the option list to pick up the 'process_manager_test.py' test.

*** 'list_available_integtests.sh' will list all available tests.

Here are suggested instructions for testing this change:

DATE_PREFIX=`date '+%d%b'`
TIME_SUFFIX=`date '+%H%M'`

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
setup_dbt latest
dbt-create -n NFD_DEV_260729_A9 ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}
cd ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}/sourcecode

git clone https://github.com/DUNE-DAQ/daqsystemtest.git -b kbiery/bundle_script_option_hints

cd ..

. ./env.sh
dbt-build -j 12
dbt-workarea-env

echo ""
echo -e "\U1F535 \U2705 Various bundle script argument combinations that now provide hints... \U2705 \U1F535"
echo ""
echo ""

dunedaq_integtest_bundle.sh -k process

sleep 3

dunedaq_integtest_bundle.sh -r trigger -k dis

sleep 3

dunedaq_integtest_bundle.sh -r trigger -k b

Type of change

• Optimization (non-breaking change that improves code/performance)

Testing checklist

• Full set of integration tests pass (dunedaq_integtest_bundle.sh)

[PawelPlesniak]

Thank you for this PR @bieryAtFnal, I ran the suggested script and it implemented the desired functionality.

🔵 ✅ Various bundle script argument combinations that now provide hints... ✅ 🔵



Integtests from the _daqsystemtest_ repo will be run...
...Looking for integtests...

*** No integtests were found that matched the specified command-line options.

*** Consider adding '-r drunc' to the option list to pick up the 'process_manager_test.py' test.

*** 'list_available_integtests.sh' will list all available tests.

...Looking for integtests...

*** No integtests were found that matched the specified command-line options.

*** Consider adding '-r daqsystemtest' to the option list to pick up the 'disabled_tpg_test.py' test.
*** And/or '-r dfmodules' to pick up the 'disabled_output_test.py' test.
*** And/or '-r dfmodules' to pick up the 'insufficient_disk_space_test.py' test.
*** Or '-r all' to pick up all of these tests.

*** 'list_available_integtests.sh' will list all available tests.

...Looking for integtests...

*** No integtests were found that matched the specified command-line options.

*** Consider adding '-r crtmodules' to the option list to pick up the 'crt_frame_builder_test.py' test.
*** And/or '-r daqsystemtest' to pick up the 'disabled_tpg_test.py' test.
*** And/or '-r daqsystemtest' to pick up the 'trigger_bitwords_test.py' test.
*** And/or '-r dfmodules' to pick up the 'disabled_output_test.py' test.
*** And/or '-r hsilibs' to pick up the 'iceberg_real_hsi_test.py' test.
*** Or '-r all' to pick up all of these tests.

*** 'list_available_integtests.sh' will list all available tests.

I extended it by also running the following commands, which worked as expected

dunedaq_integtest_bundle.sh
dunedaq_integtest_bundle.sh -k minimal

I have a question about this option

--no-integtest-connsvc : Whether to disable the Connectivity Service for this test

I just wanted to confirm - is this option is intended for the user running this test to deploy their own instance of the connectivity service? If so, running with it assumes the connection details specified in

daqsystemtest/config/daqsystemtest/ccm.data.xml

Lines 106 to 110 in c9f842b

	<obj class="ConnectivityService" id="local-connectivity-service-config">
	<attr name="interval_ms" type="u32" val="2000"/>
	<attr name="host" type="string" val="localhost"/>
	<rel name="service" class="Service" id="local-connectivity-service"/>
	</obj>

If this is the case, the user should be informed that the configurations specify an expected address for the conn srv to be running

[PawelPlesniak]

Should be merged, not merging myself subject to disucssion of the comment

[bieryAtFnal]

@PawelPlesniak , thanks for your review of this PR and your feedback on the --no-integtest-connsvc option. I have talked with Eric and put together a couple of PRs that attempt to remedy the confusing state of that option (DUNE-DAQ/daqconf#634 and DUNE-DAQ/integrationtest#169). Please take a look at those and let me know if what they describe sounds reasonable.

In the meantime, I'll go ahead and merge the changes in this PR.