Skip to content

NSA-9931: Fix Entra registration race condition #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AhmadiRamin wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

NSA-9931: Fix Entra registration race condition #238

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ddf3066
Add unique index on [user].email to prevent duplicate registrations
AhmadiRamin Aug 3, 2026
b95ff0f
Document scope limitation of Email_MustBeUnique on collation-sensitivity
AhmadiRamin Aug 3, 2026
a1aafbe
Recover from concurrent registration race instead of failing
AhmadiRamin Aug 3, 2026
d4254a0
Audit permanent Entra linking failures instead of silently dropping them
AhmadiRamin Aug 3, 2026
d5e9cc8
Address final review findings for NSA-9931 registration race fix
AhmadiRamin Aug 4, 2026
0c90c77
Potential fix for pull request finding
AhmadiRamin Aug 10, 2026
688631d
[NSA-9931] fix: remove duplicated outcomeGuidance block in TokenIssua…
AhmadiRamin Aug 10, 2026
023bd86
[NSA-9931] refactor: drop EF Core migrations for the unique email index
AhmadiRamin Aug 10, 2026
941dc9c
[NSA-9931] fix: address Copilot review finding in CreateUserUseCase r…
AhmadiRamin Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,5 +125,7 @@
<!-- Mocking -->
<PackageVersion Include="Moq" Version="4.20.72" />
<PackageVersion Include="Moq.AutoMock" Version="3.5.0" />
<!-- Relational-constraint testing (EF Core InMemory provider does not enforce unique indexes) -->
<PackageVersion Include="Microsoft.EntityFrameworkCore.Sqlite" Version="9.0.9" />
</ItemGroup>
</Project>
14 changes: 14 additions & 0 deletions dsi-platform.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Dfe.SignIn.AppHost", "src\D
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Dfe.SignIn.ServiceDefaults", "src\Dfe.SignIn.ServiceDefaults\Dfe.SignIn.ServiceDefaults.csproj", "{282680D1-4103-4AC6-9238-0038A937DAA2}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "migrations", "migrations\migrations.csproj", "{4C276B0D-1D14-46CF-896D-FC296AFD30DA}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -717,6 +719,18 @@ Global
{282680D1-4103-4AC6-9238-0038A937DAA2}.Release|x64.Build.0 = Release|Any CPU
{282680D1-4103-4AC6-9238-0038A937DAA2}.Release|x86.ActiveCfg = Release|Any CPU
{282680D1-4103-4AC6-9238-0038A937DAA2}.Release|x86.Build.0 = Release|Any CPU
{4C276B0D-1D14-46CF-896D-FC296AFD30DA}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{4C276B0D-1D14-46CF-896D-FC296AFD30DA}.Debug|Any CPU.Build.0 = Debug|Any CPU
{4C276B0D-1D14-46CF-896D-FC296AFD30DA}.Debug|x64.ActiveCfg = Debug|Any CPU
{4C276B0D-1D14-46CF-896D-FC296AFD30DA}.Debug|x64.Build.0 = Debug|Any CPU
{4C276B0D-1D14-46CF-896D-FC296AFD30DA}.Debug|x86.ActiveCfg = Debug|Any CPU
{4C276B0D-1D14-46CF-896D-FC296AFD30DA}.Debug|x86.Build.0 = Debug|Any CPU
{4C276B0D-1D14-46CF-896D-FC296AFD30DA}.Release|Any CPU.ActiveCfg = Release|Any CPU
{4C276B0D-1D14-46CF-896D-FC296AFD30DA}.Release|Any CPU.Build.0 = Release|Any CPU
{4C276B0D-1D14-46CF-896D-FC296AFD30DA}.Release|x64.ActiveCfg = Release|Any CPU
{4C276B0D-1D14-46CF-896D-FC296AFD30DA}.Release|x64.Build.0 = Release|Any CPU
{4C276B0D-1D14-46CF-896D-FC296AFD30DA}.Release|x86.ActiveCfg = Release|Any CPU
{4C276B0D-1D14-46CF-896D-FC296AFD30DA}.Release|x86.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
Loading
Loading