Feat/initiate email change - #211
Quality Gate failed
Failed conditions
Annotations
Check warning on line 9 in src/Dfe.SignIn.Core.UseCases/Users/CodeGenerator.cs
sonarqubecloud / SonarCloud Code Analysis
Missing XML comment for publicly visible type or member 'CodeGenerator.DecCharset'
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9KvJdh-hUgUGraXPFM&open=AZ9KvJdh-hUgUGraXPFM&pullRequest=211
Check warning on line 11 in src/Dfe.SignIn.Core.UseCases/Users/CodeGenerator.cs
sonarqubecloud / SonarCloud Code Analysis
Missing XML comment for publicly visible type or member 'CodeGenerator.FullCharset'
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9KvJdh-hUgUGraXPFN&open=AZ9KvJdh-hUgUGraXPFN&pullRequest=211
sonarqubecloud / SonarCloud Code Analysis
Dereference of a possibly null reference.
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9KvJZX-hUgUGraXPFH&open=AZ9KvJZX-hUgUGraXPFH&pullRequest=211
Check warning on line 139 in src/Dfe.SignIn.Core.UseCases/Users/InitiateChangeEmailAddressUseCase.cs
sonarqubecloud / SonarCloud Code Analysis
'System.Exception' should not be thrown by user code.
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9H2YXigd6BrlzEoa-v&open=AZ9H2YXigd6BrlzEoa-v&pullRequest=211
Check warning on line 115 in src/Dfe.SignIn.Core.UseCases/Users/InitiateChangeEmailAddressUseCase.cs
sonarqubecloud / SonarCloud Code Analysis
Use PascalCase for named placeholders.
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9KwktzgXSPa0M34WQL&open=AZ9KwktzgXSPa0M34WQL&pullRequest=211
Check warning on line 5 in src/Dfe.SignIn.Core.UseCases/Users/CodeGenerator.cs
sonarqubecloud / SonarCloud Code Analysis
Missing XML comment for publicly visible type or member 'CodeGenerator'
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9KvJdh-hUgUGraXPFK&open=AZ9KvJdh-hUgUGraXPFK&pullRequest=211
Check warning on line 218 in src/Dfe.SignIn.Core.UseCases/Users/InitiateChangeEmailAddressUseCase.cs
sonarqubecloud / SonarCloud Code Analysis
Member 'GenerateResetCode' does not access instance data and can be marked as static
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9H2YXigd6BrlzEoa-8&open=AZ9H2YXigd6BrlzEoa-8&pullRequest=211
sonarqubecloud / SonarCloud Code Analysis
Use 'Assert.HasCount' instead of 'Assert.AreEqual'
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9KvJZX-hUgUGraXPFI&open=AZ9KvJZX-hUgUGraXPFI&pullRequest=211
Check warning on line 115 in src/Dfe.SignIn.Core.UseCases/Users/InitiateChangeEmailAddressUseCase.cs
sonarqubecloud / SonarCloud Code Analysis
Logging arguments should be passed to the correct parameter.
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9KwktzgXSPa0M34WQK&open=AZ9KwktzgXSPa0M34WQK&pullRequest=211
Check warning on line 30 in src/Dfe.SignIn.Core.UseCases/Users/CodeGenerator.cs
sonarqubecloud / SonarCloud Code Analysis
Use a StringBuilder instead.
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9KvJdh-hUgUGraXPFJ&open=AZ9KvJdh-hUgUGraXPFJ&pullRequest=211
Check warning on line 23 in src/Dfe.SignIn.Core.UseCases/Users/CodeGenerator.cs
sonarqubecloud / SonarCloud Code Analysis
Missing XML comment for publicly visible type or member 'CodeGenerator.Generate(int, string?)'
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9KvJdh-hUgUGraXPFO&open=AZ9KvJdh-hUgUGraXPFO&pullRequest=211
Check warning on line 218 in src/Dfe.SignIn.Core.UseCases/Users/InitiateChangeEmailAddressUseCase.cs
sonarqubecloud / SonarCloud Code Analysis
Make 'GenerateResetCode' a static method.
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9H2YXigd6BrlzEoa-w&open=AZ9H2YXigd6BrlzEoa-w&pullRequest=211
sonarqubecloud / SonarCloud Code Analysis
Remove this commented out code.
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9H2YUpgd6BrlzEoa-o&open=AZ9H2YUpgd6BrlzEoa-o&pullRequest=211
Check warning on line 7 in src/Dfe.SignIn.Core.UseCases/Users/CodeGenerator.cs
sonarqubecloud / SonarCloud Code Analysis
Missing XML comment for publicly visible type or member 'CodeGenerator.NumericCharset'
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9KvJdh-hUgUGraXPFL&open=AZ9KvJdh-hUgUGraXPFL&pullRequest=211
Check warning on line 114 in src/Dfe.SignIn.Core.UseCases/Users/InitiateChangeEmailAddressUseCase.cs
sonarqubecloud / SonarCloud Code Analysis
Either log this exception and handle it, or rethrow it with some contextual information.
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9KwktzgXSPa0M34WQJ&open=AZ9KwktzgXSPa0M34WQJ&pullRequest=211
Check warning on line 107 in src/Dfe.SignIn.Core.UseCases/Users/InitiateChangeEmailAddressUseCase.cs
sonarqubecloud / SonarCloud Code Analysis
Await FirstOrDefaultAsync instead.
See more on https://sonarcloud.io/project/issues?id=DFE-Digital_dsi-platform&issues=AZ9H2YXigd6BrlzEoa-t&open=AZ9H2YXigd6BrlzEoa-t&pullRequest=211