Skip to content

Set up documentation #36

Open
Open

Activity

  1. jiweiqi commented on Apr 30, 2021

    @jiweiqi
    ContributorAuthor
  2. changed the title [-]Set up documentation in a separate repo[/-] [+]Set up documentation[/+] on Apr 30, 2021
  3. pinned this issue on May 5, 2021
  4. jiweiqi commented on May 7, 2021

    @jiweiqi
    ContributorAuthor

    @RSuryaNarayan You can start from this example to get familiar with Arrhenius.jl

  5. RSuryaNarayan commented on May 7, 2021

    @RSuryaNarayan
    Contributor

    Sure @jiweiqi ! Shall go through.

  6. RSuryaNarayan commented on May 9, 2021

    @RSuryaNarayan
    Contributor
  7. jiweiqi commented on May 9, 2021

    @jiweiqi
    ContributorAuthor

    @RSuryaNarayan I think it is a good practice to send a PR and get familiar with it.

  8. RSuryaNarayan commented on May 9, 2021

    @RSuryaNarayan
    Contributor

    Sure @jiweiqi I shall send the PR right away

  9. jiweiqi commented on May 9, 2021

    @jiweiqi
    ContributorAuthor

    @RSuryaNarayan A very minor remind, you may forget to specify the language for the following code block

    @inbounds function dudt!(du, u, p, t)
        T = u[end]
        Y = @view(u[1:ns])
        mean_MW = 1. / dot(Y, 1 ./ gas.MW)
        ρ_mass = P / R / T * mean_MW
        X = Y2X(gas, Y, mean_MW)
        C = Y2C(gas, Y, ρ_mass)
        cp_mole, cp_mass = get_cp(gas, T, X, mean_MW)
        h_mole = get_H(gas, T, Y, X)
        S0 = get_S(gas, T, P, X)
        wdot = wdot_func(gas.reaction, T, C, S0, h_mole)
        Ydot = wdot / ρ_mass .* gas.MW
        Tdot = -dot(h_mole, wdot) / ρ_mass / cp_mass
        du .= vcat(Ydot, Tdot)
    end

    Without specifying language,

    @inbounds function dudt!(du, u, p, t)
        T = u[end]
        Y = @view(u[1:ns])
        mean_MW = 1. / dot(Y, 1 ./ gas.MW)
        ρ_mass = P / R / T * mean_MW
        X = Y2X(gas, Y, mean_MW)
        C = Y2C(gas, Y, ρ_mass)
        cp_mole, cp_mass = get_cp(gas, T, X, mean_MW)
        h_mole = get_H(gas, T, Y, X)
        S0 = get_S(gas, T, P, X)
        wdot = wdot_func(gas.reaction, T, C, S0, h_mole)
        Ydot = wdot / ρ_mass .* gas.MW
        Tdot = -dot(h_mole, wdot) / ρ_mass / cp_mass
        du .= vcat(Ydot, Tdot)
    end
    
  10. jiweiqi commented on May 9, 2021

    @jiweiqi
    ContributorAuthor

    @RSuryaNarayan BTW, it seems that .svg can not be correctly displayed on the website. You may try .png next time.

  11. RSuryaNarayan commented on May 9, 2021

    @RSuryaNarayan
    Contributor

    Ah sorry for these bugs @jiweiqi shall correct them next time

  12. RSuryaNarayan commented on May 9, 2021

    @RSuryaNarayan
    Contributor

    @jiweiqi the PNG doesn't render in the preview of the markdown for some reason. I have committed it nonetheless. Pls check the new PR

  13. jiweiqi commented on May 9, 2021

    @jiweiqi
    ContributorAuthor

    I think the PNG file generated has something wrong. You can see an example here https://github.com/DENG-MIT/Arrhenius.jl/blob/main/docs/src/figures/schem.png.

  14. RSuryaNarayan commented on May 9, 2021

    @RSuryaNarayan
    Contributor

    Aha no @jiweiqi that is not the problem. I meant the PNG file itself doesn't render as an image after I upload it.

  15. jiweiqi commented on May 9, 2021

    @jiweiqi
    ContributorAuthor

    Oh, it is alright. We can fix it later.
    Can you show me the code you used to save the plot to a file in Julia.

  16. jiweiqi commented on May 9, 2021

    @jiweiqi
    ContributorAuthor

    I was using this one png(pltsum, "JP10_pyrolysis.png"). This should give a png file. It seems the file you uploaded is still in svg format.

  17. RSuryaNarayan commented on May 9, 2021

    @RSuryaNarayan
    Contributor

    @jiweiqi I seem to have used the right format now. It still doesn't render ryt?

  18. jiweiqi commented on May 9, 2021

    @jiweiqi
    ContributorAuthor

    @RSuryaNarayan I just fixed it by changing the file path as ![](./figures/JP10.png).

  19. added 2 commits that reference this issue on Oct 16, 2026
  20. unpinned this issue on Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

documentationImprovements or additions to documentation

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions