Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two installation-time settings interact poorly with current Hermes:
get_config("model")becausemodelis a reserved core root. The router silently catches that exception, emits repeatedRejected config path 'model'warnings, and always falls back tojev-latest. Rename the plugin setting torouter_modelwhile retaining the client'smodelargument and document the change.cache.jsonlives inside this plugin's buildable directory. Hermes includes non-excluded plugin files in its dependency stamp, so each answer cache rewrite can make the next CLI launch reportvenv: out of sync with uv.lockand repeat the source-update dependency/desktop build. Put the default cache under<hermes home>/cache/typesafe-skill-router.jsoninstead. Explicit cache overrides remain supported.The README notes that the previous cache is not automatically migrated and describes how to preserve it before restarting; leaving
cache_pathpointed into the buildable plugin tree reproduces the stamp problem.Verification
router_modelandcache_pathreach the System One client.uv run --no-project --with pytest --with pyyaml python -m pytest tests -q: 68 passed on macOS.default,maic,membr,murmrcore,nyra) with a successful TypeSafe probe per profile. These local profiles use explicit external cache paths until this fix is released.