Repository navigation
Remove unused target dependencies - #221
Open
tomas-martins-crossmint wants to merge 1 commit into
Open
tomas-martins-crossmint wants to merge 1 commit into
tomas-martins-crossmint wants to merge 1 commit into
Conversation
tomas-martins-crossmint
marked this pull request as ready for review
October 29, 2026 00:16
Contributor
[Low impact] This PR appears safe to merge; no actionable issues were found. Reviews (1) · Last reviewed commit: "Remove unused target dependencies from P..." · Reviewed by Greptile |
albertoelias-crossmint
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes 7 internal dependencies from
Package.swiftthat no code uses. Apps that use the SDK see no change.Before, some targets linked modules they never import, so they waited on extra modules to build. Now each target lists only the modules it imports.
Changes
CrossmintCommonTypes,CrossmintServiceandPasskeysno longer depend onLoggerSecureStorageno longer depends onUtilsCrossmintCommonTypesTestsandWebTestsdropTestsUtilsandHttp, which they don't importUtilsTestsdepends onUtilsdirectly instead ofTestsUtils, since it importsUtilsand only reached it throughTestsUtilsTest plan
make test: all 632 tests pass, run from an empty build cachemake lintfinds 0 problems, and the demo app, the release archive andCrossmintDeviceSignerall buildCrossmintCommonTypesandPasskeysbuilt withoutLoggerbeing built at all.