Skip to content

Remove unused target dependencies - #221

Open
tomas-martins-crossmint wants to merge 1 commit into
mainfrom
tomas/remove-unused-target-deps
Open

tomas-martins-crossmint wants to merge 1 commit into
mainfrom
tomas/remove-unused-target-deps

Conversation

@tomas-martins-crossmint

Copy link
Copy Markdown
Contributor

This pull request removes 7 internal dependencies from Package.swift that no code uses. Apps that use the SDK see no change.

Before, some targets linked modules they never import, so they waited on extra modules to build. Now each target lists only the modules it imports.

Changes

  • CrossmintCommonTypes, CrossmintService and Passkeys no longer depend on Logger
  • SecureStorage no longer depends on Utils
  • CrossmintCommonTypesTests and WebTests drop TestsUtils and Http, which they don't import
  • UtilsTests depends on Utils directly instead of TestsUtils, since it imports Utils and only reached it through TestsUtils
  • All outside packages stay, because each one is still imported

Test plan

  • make test: all 632 tests pass, run from an empty build cache
  • make lint finds 0 problems, and the demo app, the release archive and CrossmintDeviceSigner all build
  • I built each changed target alone from an empty cache, so a missing dependency can't be hidden by another target building it first. CrossmintCommonTypes and Passkeys built without Logger being built at all.
  • Integration tests were not run, because none of their dependencies changed

@tomas-martins-crossmint
tomas-martins-crossmint marked this pull request as ready for review October 29, 2026 00:16
@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge; no actionable issues were found.

Reviews (1) · Last reviewed commit: "Remove unused target dependencies from P..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants