Repository navigation
Read quorum signers on wallets - #202
Open
tomas-martins-crossmint wants to merge 8 commits into
Open
tomas-martins-crossmint wants to merge 8 commits into
tomas-martins-crossmint wants to merge 8 commits into
Conversation
tomas-martins-crossmint
marked this pull request as ready for review
October 16, 2026 21:34
Contributor
[Medium impact] Adds quorum signer support to wallet configuration parsing. Fix default signer selection for mixed recovery lists and satisfy the repository rules before merging. Reviews (1) · Last reviewed commit: "Read quorum signers on wallets" · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request lets apps load a wallet that has a quorum as a recovery method. A quorum is a signer that approves only when a set number of its members approve, for example 2 of 3 emails
A wallet whose only recovery method is a quorum now loads, and its recovery methods list the quorum with its threshold and members
Changes
QuorumSignerDatatype with the quorumid, itsthresholdand itsmembers. Each member is a regular signer, for exampleEmailSignerDataAdminSignerDataTypehas a newquorumcaseSignerLocatorhas a newquorum(id:)case, with the string formquorum:<id>quorum:locator