Skip to content

Read quorum signers on wallets - #202

Open
tomas-martins-crossmint wants to merge 8 commits into
mainfrom
tomas/wal-13105-swift-quorum-signers-on-wallets
Open

tomas-martins-crossmint wants to merge 8 commits into
mainfrom
tomas/wal-13105-swift-quorum-signers-on-wallets

Conversation

@tomas-martins-crossmint

Copy link
Copy Markdown
Contributor

This pull request lets apps load a wallet that has a quorum as a recovery method. A quorum is a signer that approves only when a set number of its members approve, for example 2 of 3 emails

A wallet whose only recovery method is a quorum now loads, and its recovery methods list the quorum with its threshold and members

Changes

  • New public QuorumSignerData type with the quorum id, its threshold and its members. Each member is a regular signer, for example EmailSignerData
  • AdminSignerDataType has a new quorum case
  • SignerLocator has a new quorum(id:) case, with the string form quorum:<id>
  • The wallet response reads quorum entries in the recovery methods and in the admin signer. A quorum signer in the delegated signers reads as a quorum: locator
  • A quorum member whose type this SDK version does not support is left out of the members, with a warning in the logs. The quorum itself still loads
  • Tests cover a Stellar wallet whose only recovery method is a 2 of 3 quorum, the member order, and the new locator case

@tomas-martins-crossmint
tomas-martins-crossmint marked this pull request as ready for review October 16, 2026 21:34
@greptile-apps

greptile-apps Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] Adds quorum signer support to wallet configuration parsing.

Fix default signer selection for mixed recovery lists and satisfy the repository rules before merging.

Reviews (1) · Last reviewed commit: "Read quorum signers on wallets" · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant