Skip to content

Add missing header file #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashao merged 2 commits into from
Sep 10, 2025
Merged

Add missing header file #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36545ca
Add missing header file
ashao Sep 10, 2025
6938651
Merge branch 'develop' into missing_header
ashao Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ To be released at a future time.

Description

- Add missing header file to scalarfield.h
- Fix a segfault in the dataset destructor
- Update supported Python versions to 3.10, 3.11, and 3.12
- Bump versions for upload/download-artifact Github Actions
Expand All @@ -16,6 +17,10 @@ Description
- Reenable move semantics and fix compiler warnings.

Detailed Notes
- When including scalarfield.h into an application,
MetadataBuffer was never defined. Add an explicit include
to the header file to ensure that applications can build.
([PR530](https://github.com/CrayLabs/SmartRedis/pull/530))
- For compilers that automatically call the dataset
destructor when the object goes out of scope, a segfault
was being triggered if the user was also explictly calling
Expand Down
1 change: 1 addition & 0 deletions include/scalarfield.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#ifndef SMARTREDIS_SCALARFIELD_H
#define SMARTREDIS_SCALARFIELD_H

#include "metadatabuffer.h"
#include "metadatafield.h"
#include <iostream>

Expand Down
Loading