Restore Hummingbird 65532 user exclusion in interactive users OVAL macro - #15066
Merged
Mab879 merged 1 commit intoAug 27, 2026
Conversation
PR ComplianceAsCode#15008 migrated file_groupownership_home_directories (and the other interactive-user checks that share create_interactive_users_list_object) from the local /etc/passwd macro to the getpwent-based one, but the getpwent macro never carried the Hummingbird-specific carve-out that excludes the special "container user" named 65532. On Hummingbird distroless images that account has UID 65532, primary group 0, and home /home/build (group-owned by 65532). Without the exclusion it is treated as a regular interactive user, so file_groupownership_home_directories now compares /home/build's group (65532) against the interactive users' primary GID set ({0}) and fails, producing a false positive that the previous content did not report. Reintroduce the same product == "hummingbird" carve-out in create_interactive_users_list_object so the special user is ignored, restoring the prior behavior for all rules using this macro.
|
@ggbecker: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Mab879
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
On Hummingbird distroless images that account has UID 65532, primary group 0, and home /home/build (group-owned by 65532). Without the exclusion it is treated as a regular interactive user, so file_groupownership_home_directories now compares /home/build's group (65532) against the interactive users' primary GID set ({0}) and fails, producing a false positive that the previous content did not report.
Reintroduce the same product == "hummingbird" carve-out in create_interactive_users_list_object so the special user is ignored, restoring the prior behavior for all rules using this macro.
Rationale: