Remove unused xinetd parameter from bash_service_command macro - #15027
Open
ggbecker wants to merge 1 commit into
Open
Remove unused xinetd parameter from bash_service_command macro#15027ggbecker wants to merge 1 commit into
ggbecker wants to merge 1 commit into
Conversation
The xinetd parameter in bash_service_command has never been used in the codebase and contains inverted logic (a 7+ year old bug where disabling a service sets disable=no, enabling it). Since: - The parameter is not used anywhere in rules or templates - A dedicated xinetd_service_disabled template exists with correct logic - xinetd has been removed from RHEL 9, RHEL 10, and OL9 - xinetd is obsolete on modern systems Remove the dead code rather than fixing the bug. Changes: - Remove xinetd parameter from bash_service_command signature - Remove xinetd example from documentation - Remove xinetd parameter documentation - Remove buggy xinetd code block (lines 735-742) This cleanup removes confusing, buggy, and unused code without any functional impact since the parameter was never actually utilized.
|
@ggbecker: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
|
/packit retest-failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The xinetd parameter in bash_service_command has never been used in the codebase and contains inverted logic (a 7+ year old bug where disabling a service sets disable=no, enabling it).
Since:
Remove the dead code rather than fixing the bug.
Changes:
This cleanup removes confusing, buggy, and unused code without any functional impact since the parameter was never actually utilized.