Change scope of grub2_bootloader_argument templated tests - #15026
Merged
Mab879 merged 1 commit intoAug 25, 2026
Conversation
jan-cerny
requested review from
Mab879,
matusmarhefka and
vojtapolasek
as code owners
August 20, 2026 12:11
jan-cerny
added
the
productization-issue
jan-cerny
added
the
backported-into-stabilization
Mab879
requested changes
Aug 24, 2026
Mab879
left a comment
Mab879
left a comment
Member
There was a problem hiding this comment.
After review the build tests you adjust the Jinja templates to remove the extra white space.
#!/bin/bash
# platform = multi_platform_fedora,multi_platform_rhel
# packages = grub2,grubby
# variables = var_rng_core_default_quality=99999
source common.sh| {{% else %}} | ||
| # platform = Oracle Linux 8,Red Hat Enterprise Linux 8 | ||
| {{% endif %}} | ||
|
|
Some test scenarios test correct handling of *values* of bootloader arguments. But, not all arguments have values, some arguments are value-less, for example `nousb`. For the value-less arguments it doesn't make sense to test the correct handling of values. Some tests that currently attempt to do this are broken. We will fix it by disabling the test scenarios. We will use the well-known "trick" of setting the `# platform` header to `Not Applicable` if the bootloader argument isn't supposed to have any value. These are rules where the template isn't given the `arg_value` or `arg_variable` parameter. Fixes failing templated test scenario `wrong_value_entries.fail.sh` in rule `grub2_nousb_argument`.
jan-cerny
force-pushed
the
grub2_bootloader_argument_test
branch
from
August 25, 2026 06:23
32ed08d to
4868264
Compare
Member
Author
|
I have removed the empty line |
|
@jan-cerny: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Mab879
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some test scenarios test correct handling of values of bootloader arguments. But, not all arguments have values, some arguments are value-less, for example
nousb. For the value-less arguments it doesn't make sense to test the correct handling of values. Some tests that currently attempt to do this are broken.We will fix it by disabling the test scenarios.
We will use the well-known "trick" of setting the
# platformheader toNot Applicableif the bootloader argument isn't supposed to have any value. These are rules where the template isn't given thearg_valueorarg_variableparameter.Fixes failing templated test scenario
wrong_value_entries.fail.shin rulegrub2_nousb_argument.Review Hints:
run automatus or /per-rule for all rules using the template grub2_bootloader_argument