Skip to content

controls/cis_debian13: fix section 5 title typos and complete 5.1.13 - #14983

Merged
jan-cerny merged 1 commit into
ComplianceAsCode:masterfrom
israel-villar:feat/debian13-cis-section5-fixes
Aug 12, 2026
Merged

controls/cis_debian13: fix section 5 title typos and complete 5.1.13#14983
jan-cerny merged 1 commit into
ComplianceAsCode:masterfrom
israel-villar:feat/debian13-cis-section5-fixes

Conversation

@israel-villar

Copy link
Copy Markdown
Contributor

Description:

  • Fix three title mismatches against the CIS Debian Linux 13 Benchmark v1.0.0 PDF, and complete control 5.1.13 (post-quantum SSH key exchange), converting it from pending to automated.

Rationale:

  • 5.1.1: title had a typo, access_to instead of access to.
  • 5.2.6: title read "Ensure sudo authentication timeout is configured correctly"; the benchmark's actual title is "Ensure sudo timestamp_timeout is configured". Rule mapping (var_sudo_timestamp_timeout, sudo_require_reauthentication) was already correct, only the title was off.
  • 5.3.3.2.2: title read "Ensure minimum password length is configured"; the benchmark's actual title is "Ensure password length is configured". Rule mapping was already correct.
  • 5.1.13 ("Ensure sshd post-quantum cryptography key exchange algorithms are configured"): the PDF's Audit section for 5.1.13 checks the same KexAlgorithms line in /etc/ssh/sshd_config as control 5.1.12, just verifying that the post-quantum algorithms (sntrup761x25519-sha512, and for OpenSSH >= 9.9, mlkem768x25519-sha256) are present in it. The cis_debian13 value of the sshd_strong_kex variable (linux_os/guide/services/ssh/sshd_strong_kex.var) already lists both of those algorithms first. So the same rule mapping used for 5.1.12 (sshd_strong_kex=cis_debian13 + sshd_use_strong_kex) satisfies 5.1.13 too — there's no separate check or remediation needed. Added a notes: entry explaining the reuse, following the same pattern already used for 5.1.7's partial status.

Review Hints:

  • All changes are in controls/cis_debian13.yml, section 5 (SSH Server / Privilege Escalation / PAM / User Accounts).
  • Build: ./build_product --datastream-only debian13
  • Relevant variable: linux_os/guide/services/ssh/sshd_strong_kex.var (see the cis_debian13 key).
  • These four controls were verified independently of PR Add Debian 13 PAM support to existing rules #14781 (Debian 13 PAM support) — none of the touched controls (5.1.1, 5.1.13, 5.2.6, 5.3.3.2.2) reference rules affected by that PR.

Verified against CIS Debian Linux 13 Benchmark v1.0.0 PDF:
- 5.1.1: fix typo in title (access_to -> access to)
- 5.2.6: fix title to match benchmark wording (sudo timestamp_timeout)
- 5.3.3.2.2: fix title to match benchmark wording (password length)
- 5.1.13: convert pending to automated. The post-quantum KEX audit
  checks the same KexAlgorithms line as 5.1.12, and the cis_debian13
  value of sshd_strong_kex already lists mlkem768x25519-sha256 and
  sntrup761x25519-sha512@openssh.com first, so the existing rule
  mapping from 5.1.12 satisfies this control too.
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Aug 12, 2026
@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown

Hi @israel-villar. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jan-cerny jan-cerny added this to the 0.1.82 milestone Aug 12, 2026
@jan-cerny jan-cerny added the Debian Debian product related. label Aug 12, 2026
@jan-cerny
jan-cerny merged commit 8934edb into ComplianceAsCode:master Aug 12, 2026
59 of 60 checks passed
@israel-villar
israel-villar deleted the feat/debian13-cis-section5-fixes branch August 12, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Debian Debian product related. needs-ok-to-test Used by openshift-ci bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants