-
Notifications
You must be signed in to change notification settings - Fork 87
GradientSlider component creation #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 33 commits
e9927d5
2c608e4
1028e20
a1f814f
b6cb853
3fe66b5
f3552f4
219be4c
3f01d0a
9b7756a
22871b7
fb8175a
3c8cfdc
ecc79f2
3a68bb0
ca021d1
29246b4
a9ee9af
bfd18cf
633a05f
9e0f37c
60108d4
a1307b8
4d7e543
aa83779
b40b727
11bec84
043c0dc
589314f
401bb64
98e305c
b254ec5
6963917
31f587f
d6ec7e2
596c65d
6240b09
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| @ECHO OFF | ||
|
|
||
| powershell ..\..\tooling\ProjectHeads\GenerateSingleSampleHeads.ps1 -componentPath %CD% %* |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <!-- | ||
| WinUI 2 under UWP uses TargetFramework uap10.0.* | ||
| WinUI 3 under WinAppSdk uses TargetFramework net6.0-windows10.* | ||
| However, under Uno-powered platforms, both WinUI 2 and 3 can share the same TargetFramework. | ||
|
|
||
| MSBuild doesn't play nicely with this out of the box, so we've made it easy for you. | ||
|
|
||
| For .NET Standard packages, you can use the Nuget Package Manager in Visual Studio. | ||
| For UWP / WinAppSDK / Uno packages, place the package references here. | ||
| --> | ||
| <Project> | ||
| <!-- WinUI 2 / UWP --> | ||
| <ItemGroup Condition="'$(IsUwp)' == 'true'"> | ||
| <!-- <PackageReference Include="Microsoft.Toolkit.Uwp.UI.Controls.Primitives" Version="7.1.2"/> --> | ||
| </ItemGroup> | ||
|
|
||
| <!-- WinUI 2 / Uno --> | ||
| <ItemGroup Condition="'$(IsUno)' == 'true' AND '$(WinUIMajorVersion)' == '2'"> | ||
| <!-- <PackageReference Include="Uno.Microsoft.Toolkit.Uwp.UI.Controls.Primitives" Version="7.1.11"/> --> | ||
| </ItemGroup> | ||
|
|
||
| <!-- WinUI 3 / WinAppSdk --> | ||
| <ItemGroup Condition="'$(IsWinAppSdk)' == 'true'"> | ||
| <!-- <PackageReference Include="CommunityToolkit.WinUI.UI.Controls.Primitives" Version="7.1.2"/> --> | ||
| </ItemGroup> | ||
|
|
||
| <!-- WinUI 3 / Uno --> | ||
| <ItemGroup Condition="'$(IsUno)' == 'true' AND '$(WinUIMajorVersion)' == '3'"> | ||
| <!-- <PackageReference Include="Uno.CommunityToolkit.WinUI.UI.Controls.Primitives" Version="7.1.100-dev.15.g12261e2626"/> --> | ||
| </ItemGroup> | ||
| </Project> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <Project> | ||
| <Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.props))" Condition="Exists('$([MSBuild]::GetPathOfFileAbove(Directory.Build.props))')" /> | ||
|
|
||
| <PropertyGroup> | ||
| <ToolkitComponentName>GradientSlider</ToolkitComponentName> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- Sets this up as a toolkit component's sample project --> | ||
| <Import Project="$(ToolingDirectory)\ToolkitComponent.SampleProject.props" /> | ||
| <ItemGroup> | ||
| <Compile Update="GradientSliderSample.xaml.cs"> | ||
| <DependentUpon>GradientSliderSample.xaml</DependentUpon> | ||
| </Compile> | ||
| </ItemGroup> | ||
| </Project> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| title: GradientSlider | ||
| author: githubaccount | ||
| description: TODO: Your experiment's description here | ||
| keywords: GradientSlider, Control, Layout | ||
| dev_langs: | ||
| - csharp | ||
| category: Controls | ||
| subcategory: Layout | ||
| discussion-id: 0 | ||
| issue-id: 0 | ||
| icon: assets/icon.png | ||
| --- | ||
|
|
||
| <!-- To know about all the available Markdown syntax, Check out https://docs.microsoft.com/contribute/markdown-reference --> | ||
| <!-- Ensure you remove all comments before submission, to ensure that there are no formatting issues when displaying this page. --> | ||
| <!-- It is recommended to check how the Documentation will look in the sample app, before Merging a PR --> | ||
| <!-- **Note:** All links to other docs.microsoft.com pages should be relative without locale, i.e. for the one above would be /contribute/markdown-reference --> | ||
| <!-- Included images should be optimized for size and not include any Intellectual Property references. --> | ||
|
|
||
| <!-- Be sure to update the discussion/issue numbers above with your Labs discussion/issue id numbers in order for UI links to them from the sample app to work. --> | ||
|
|
||
| # GradientSlider | ||
|
|
||
| > [!SAMPLE GradientSliderSample] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. --> | ||
| <Page x:Class="GradientSliderExperiment.Samples.GradientSliderSample" | ||
| xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" | ||
| xmlns:controls="using:CommunityToolkit.WinUI.Controls" | ||
| xmlns:d="http://schemas.microsoft.com/expression/blend/2008" | ||
| xmlns:local="using:GradientSliderExperiment.Samples" | ||
| xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" | ||
| mc:Ignorable="d"> | ||
|
|
||
| <StackPanel Spacing="16"> | ||
| <controls:GradientSlider IsAddStopsEnabled="{x:Bind CanAddStops, Mode=OneWay}"> | ||
| <controls:GradientSlider.GradientStops> | ||
| <GradientStopCollection> | ||
| <GradientStop Offset="0" Color="#FF0000" /> | ||
| <GradientStop Offset="0.3" Color="#00FF00" /> | ||
| <GradientStop Offset="0.66" Color="#0000FF" /> | ||
| <GradientStop Offset="1" Color="#FF0000" /> | ||
| </GradientStopCollection> | ||
| </controls:GradientSlider.GradientStops> | ||
|
Comment on lines
+13
to
+20
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What happens if the developer doesn't specify any stops at the start? Could be good to have another example where it's bound to a collection (to show binding) but that collection is also empty to start?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seconded, documenting (and defining if needed) the expected behavior for empty/default properties is a trivial known/expected scenario for any component MVP. |
||
| </controls:GradientSlider> | ||
| </StackPanel> | ||
| </Page> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using CommunityToolkit.WinUI.Controls; | ||
|
|
||
| namespace GradientSliderExperiment.Samples; | ||
|
|
||
| /// <summary> | ||
| /// An example sample page of a custom control inheriting from Panel. | ||
| /// </summary> | ||
|
|
||
| [ToolkitSample(id: nameof(GradientSliderSample), "Custom control", description: $"A sample for showing how to create and use a {nameof(GradientSlider)} custom control.")] | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Default text (name/description) should be replaced so it's displayed properly in the sample app. |
||
| [ToolkitSampleBoolOption("CanAddStops", true, Title = nameof(GradientSlider.IsAddStopsEnabled))] | ||
| public sealed partial class GradientSliderSample : Page | ||
| { | ||
| public GradientSliderSample() | ||
| { | ||
| this.InitializeComponent(); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| <Project> | ||
| <Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.props))" Condition="Exists('$([MSBuild]::GetPathOfFileAbove(Directory.Build.props))')" /> | ||
|
|
||
| <PropertyGroup> | ||
| <ToolkitComponentName>GradientSlider</ToolkitComponentName> | ||
| <Description>This package contains GradientSlider.</Description> | ||
|
|
||
| <!-- Rns suffix is required for namespaces shared across projects. See https://github.com/CommunityToolkit/Labs-Windows/issues/152 --> | ||
| <RootNamespace>CommunityToolkit.WinUI.Controls.GradientSliderRns</RootNamespace> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- Sets this up as a toolkit component's source project --> | ||
| <Import Project="$(ToolingDirectory)\ToolkitComponent.SourceProject.props" /> | ||
| </Project> | ||
|
Avid29 marked this conversation as resolved.
Outdated
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <!-- | ||
| WinUI 2 under UWP uses TargetFramework uap10.0.* | ||
| WinUI 3 under WinAppSdk uses TargetFramework net6.0-windows10.* | ||
| However, under Uno-powered platforms, both WinUI 2 and 3 can share the same TargetFramework. | ||
|
|
||
| MSBuild doesn't play nicely with this out of the box, so we've made it easy for you. | ||
|
|
||
| For .NET Standard packages, you can use the Nuget Package Manager in Visual Studio. | ||
| For UWP / WinAppSDK / Uno packages, place the package references here. | ||
| --> | ||
| <Project> | ||
| <!-- WinUI 2 / UWP --> | ||
| <ItemGroup Condition="'$(IsUwp)' == 'true'"> | ||
| <!-- <PackageReference Include="Microsoft.Toolkit.Uwp.UI.Controls.Primitives" Version="7.1.2"/> --> | ||
| </ItemGroup> | ||
|
|
||
| <!-- WinUI 2 / Uno --> | ||
| <ItemGroup Condition="'$(IsUno)' == 'true' AND '$(WinUIMajorVersion)' == '2'"> | ||
| <!-- <PackageReference Include="Uno.Microsoft.Toolkit.Uwp.UI.Controls.Primitives" Version="7.1.11"/> --> | ||
| </ItemGroup> | ||
|
|
||
| <!-- WinUI 3 / WinAppSdk --> | ||
| <ItemGroup Condition="'$(IsWinAppSdk)' == 'true'"> | ||
| <!-- <PackageReference Include="CommunityToolkit.WinUI.UI.Controls.Primitives" Version="7.1.2"/> --> | ||
| </ItemGroup> | ||
|
|
||
| <!-- WinUI 3 / Uno --> | ||
| <ItemGroup Condition="'$(IsUno)' == 'true' AND '$(WinUIMajorVersion)' == '3'"> | ||
| <!-- <PackageReference Include="Uno.CommunityToolkit.WinUI.UI.Controls.Primitives" Version="7.1.100-dev.15.g12261e2626"/> --> | ||
| </ItemGroup> | ||
| </Project> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| namespace CommunityToolkit.WinUI.Controls; | ||
|
|
||
| public partial class GradientSlider | ||
| { | ||
| /// <summary> | ||
| /// Event raised when a thumb starts being dragged. | ||
| /// </summary> | ||
| public event DragStartedEventHandler? ThumbDragStarted; | ||
|
|
||
| /// <summary> | ||
| /// Event raised when a thumb ends being dragged. | ||
| /// </summary> | ||
| public event DragCompletedEventHandler? ThumbDragCompleted; | ||
|
|
||
| /// <summary> | ||
| /// Event raised when the gradient's value changes. | ||
| /// </summary> | ||
| public event EventHandler? ValueChanged; | ||
|
|
||
| /// <summary> | ||
| /// Called before the <see cref="ThumbDragStarted"/> event occurs. | ||
| /// </summary> | ||
| /// <param name="e">Event data for the event.</param> | ||
| protected virtual void OnThumbDragStarted(DragStartedEventArgs e) | ||
| { | ||
| ThumbDragStarted?.Invoke(this, e); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Called before the <see cref="ThumbDragCompleted"/> event occurs. | ||
| /// </summary> | ||
| /// <param name="e">Event data for the event.</param> | ||
| protected virtual void OnThumbDragCompleted(DragCompletedEventArgs e) | ||
| { | ||
| ThumbDragCompleted?.Invoke(this, e); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Called before the <see cref="ValueChanged"/> event occurs. | ||
| /// </summary> | ||
| protected virtual void OnValueChanged() | ||
| { | ||
| ValueChanged?.Invoke(this, EventArgs.Empty); | ||
| } | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.