fix(android): speak unsolicited Gateway completions in Standard Voice - #602
Open
Codename-11 wants to merge 2 commits into
Open
Codename-11 wants to merge 2 commits into
Codename-11 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standard Voice now speaks successful unsolicited Gateway answers in its active conversation after the original voice turn settles. The original run observer stopped at completion, while later inbound turns reached Chat without a voice-output handoff. Related to #545.
Changes
Verification
scripts/android-lane.ps1 gradle :app:testSideloadDebugUnitTest --tests '*VoiceInboundCompletionTest' --tests '*ChatViewModelGatewayInboundTurnTest' --tests '*VoiceViewModelBargeInTest' --tests '*VoiceViewModelRealtimeSessionFenceTest' --tests '*VoiceTurnSessionFenceTest' :app:compileSideloadDebugAndroidTestKotlin --console=plainpassed (183 tests).VoiceInboundCompletionTestrerun passed all 13 cases after adding fresh-session adoption, pending-synthesis cancellation, and engine-switch-back coverage. Both corrected catalog/recovery tests also passed locally.standardPhoneApi36SideloadDebugAndroidTest, selectingGatewayExternalFixtureInstrumentedTest#unsolicitedVoiceCompletions_surviveActivityPauseWithoutHistorySpeech, passed: 1 test, 0 skipped. Synthetic Standard audio produced exactly three synthesis requests across Activity pause/resume.python -W error::ResourceWarning -m unittest discover -s test-fixtures/vanilla-gateway/tests -v: 32 passed. Gateway script tests and Android prepush helper tests passed.check-gateway-scenario-conformance.pypassed forunsolicited_voice_completions.jsonandsubagent_child_preview.jsonagainst clean upstream1a990f30628c25fb83d29c4d3b3d18dcb085406e.git diff --checkpassed.2d202bdeacfbbfbaced837459b59599d83dae1ff. Physical-device/provider audio was not tested. The final follow-up changes JVM test synchronization only; emulator-tested production sources are unchanged.Screenshots
No visual change
Compatibility / risk
Uses the existing upstream Gateway events and configured Voice Output. No Relay plugin requirement, new protocol, routing change, permission, dependency, or migration. Realtime Agent keeps its existing behavior.
Only successful live admitted answers create speech. History and terminal-gap recovery stay silent; they cannot prove a fresh complete answer for narration. Active microphone capture finishes before queued speech starts. Emulator evidence covers dispatch and lifecycle with silent WAVs, not physical microphone/audio hardware or a live TTS provider.
Server/plugin, Desktop, and translation changes are N/A. Documentation changes are prose only; no site routes or build configuration changed.
Lineage / contributor credit
Checklist
dev, unless this is adev→mainrelease PR or a focused production-tag hotfix PR tomainCHANGELOG.mdis updated for user-visible changes, or N/A is listed above