fix(feedback): prevents issue submission when no github account is co…#2184
Open
amonrperes wants to merge 1 commit into
Open
fix(feedback): prevents issue submission when no github account is co…#2184amonrperes wants to merge 1 commit into
amonrperes wants to merge 1 commit into
Conversation
…nfigured Display an alert when users attempt to submit feedback without a connected GitHub account instead of trying to create the issue. Injects github account through parameter into viewModel.
Author
|
Waiting for your review @austincondiff , @lukepistrol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nfigured
Display an alert when users attempt to submit feedback without a connected GitHub account instead of trying to create the issue. Injects github account through parameter into viewModel.
Description
When an user attempts to submit feedback, but has no github account registered it will trigger the "No GitHub account" alert. The githubAccounts constant was removed from FeedbackModel as now it's used in FeedbackView to check wether the user has a github account connected. The account name now is passed to createIssue method through parameter.
Redirection to source control was not treated as it gets outside of the issue's scope.
Related Issues
🐞 CodeEdit crashes when doing a bug report
2174
Checklist
Screenshots