fix: sync upstream 1.18.3 emoji updates and align mobile emoji UI#140
Merged
Conversation
…ent#957) <!-- Please read https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before submitting your pull request --> ### Description <!-- Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change. --> Title, for details on emoji changes check the sable twemoji repo. Also updated various dependencies that have new minor versions, tried to avoid anything that could be breaking so should be pretty safe. Also also, updates build target to ES2022. So. Uh. Hopefully no one is still using tech that doesn't support that? Prior to this change Vite by default aimed to support ES2020, but safari 14 has some problems that prevented compiling so I bumped it. #### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings ### AI disclosure: - [ ] Partially AI assisted (clarify which code was AI assisted and briefly explain what it does). - [ ] Fully AI generated (explain what all the generated code does in moderate detail). <!-- Write any explanation required here, but do not generate the explanation using AI!! You must prove you understand what the code in this PR does. -->
> [!IMPORTANT] > Merging this PR will create a new release. ## Fixes * Fixed broken Twemoji rendering and updated emoji picker, autocomplete, and jumbo detection for new emojis. ([SableClient#957](<SableClient#957>) by @7w1) * Updated various dependencies. ([SableClient#957](<SableClient#957>) by @7w1)
Code Coverage OverviewLanguages: JavaScript JavaScript / code-coverage/vitestThe overall coverage remains at 23%, unchanged from the branch. Updated |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1450f7088
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-140-charm.justin-tech.workers.dev | 4e1be40 | pr-140 |
Wed, 17 Jun 2026 23:46:27 GMT |
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sync the latest
upstream/dev(v1.18.3) into Charm and keep the upstream emoji fixes as the source of truth, then apply a small Charm-side follow-up for the remaining mobile emoji regressions.This pulls in upstream Twemoji and emoji-list updates from SableClient#957 and the published Twemoji font work from SableClient#950 / SableClient#958, while preserving Charm-specific runtime and Tauri behavior.
Charm follow-up in this branch:
Related recent Charm work: #136, #138, #139
Fixes #
Type of change
Checklist:
AI disclosure:
This branch resolves the upstream/dev merge into Charm's integration line, keeps Charm-only package/runtime differences where they overlap with upstream, regenerates the dependency lockfile for the merged manifest, updates emoji detection to use the refreshed upstream Twemoji and emoji data, removes transform-based emoji alignment tweaks that were still causing mobile picker/timeline drift, removes the picker sidebar offset hack that was pushing category icons out of place on narrow layouts, and adds a regression test for inline/jumbo emoji handling with the updated regex path.