Skip to content

ci: switch test_cloud to the CONNECTORS_TEAM_TESTS_CLOUD_* secrets - #774

Merged
BentsiLeviav merged 1 commit into
mainfrom
ci/connectors-cloud-secrets
Nov 1, 2026
Merged

BentsiLeviav merged 1 commit into
mainfrom
ci/connectors-cloud-secrets

Conversation

@BentsiLeviav

@BentsiLeviav BentsiLeviav commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Why

The nightly test_cloud workflow fails on every run. The HTTP step errors out on all 261 tests with the same message, and the native step is skipped:

Code: 194. DB::Exception: default: Authentication failed: password is incorrect, or there is no user with such name

The job reads INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT / INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD_SMT. That password is stale since the Cloud test credentials were rotated in October. The repo also carries repo-level secrets with the same names from Dec 2025, which shadow the org ones and are equally stale.

What

Point test_cloud at the Connectors team's test service via the org-level CONNECTORS_TEAM_TESTS_CLOUD_HOST / CONNECTORS_TEAM_TESTS_CLOUD_PASSWORD secrets, the same ones spark-clickhouse-connector switched to in ClickHouse/spark-clickhouse-connector#593. Two lines changed in .github/workflows/test_cloud.yml. Both secrets are already visible to this repository.

The target is a SharedMergeTree Cloud service like the previous one, so DBT_CH_TEST_CLUSTER_MODE and DBT_CH_TEST_CLOUD stay as they are. The service is cleaned hourly by ClickHouse/connectors' cloud-instance-cleanup workflow, which drops leftover test databases older than 3 hours.

After merge

Dispatch test_cloud by hand once to confirm, and delete the two stale INTEGRATIONS_TEAM_TESTS_CLOUD_*_SMT repo-level secrets so nobody picks them up again.


Note

Low Risk
CI-only workflow env var change with no application or runtime behavior impact.

Overview
Fixes failing nightly test_cloud runs by pointing DBT_CH_TEST_HOST and DBT_CH_TEST_PASSWORD at org secrets CONNECTORS_TEAM_TESTS_CLOUD_HOST / CONNECTORS_TEAM_TESTS_CLOUD_PASSWORD instead of the stale INTEGRATIONS_TEAM_TESTS_CLOUD_*_SMT pair (rotated credentials were causing auth failures across the HTTP pytest step).

SharedMergeTree Cloud test settings (DBT_CH_TEST_CLUSTER_MODE, DBT_CH_TEST_CLOUD, ports/steps) are unchanged—only the secret names in .github/workflows/test_cloud.yml are updated, aligned with what other Connectors tooling uses.

Reviewed by Cursor Bugbot for commit 3af2280. Bugbot is set up for automated code reviews on this repo. Configure here.

The nightly test_cloud job has failed with "Code: 194. Authentication
failed: password is incorrect" on every run (261 errors per run). It reads
INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT / _PASSWORD_SMT, whose password is
stale since the Cloud test credentials were rotated in October.

Point it at the Connectors team's test service via the org-level
CONNECTORS_TEAM_TESTS_CLOUD_HOST / _PASSWORD secrets instead, matching
spark-clickhouse-connector (#593).

@canbekley canbekley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! test_cloud seems to run fine now.

@BentsiLeviav
BentsiLeviav merged commit dfe9c20 into main Nov 1, 2026
14 of 15 checks passed
@canbekley

Copy link
Copy Markdown
Contributor

actually tests/integration/adapter/dictionary/test_dictionary.py::TestUpdateLagDictionary::test_create has failed, but it looks like that test might be flaky. can look into it.

@BentsiLeviav

Copy link
Copy Markdown
Collaborator Author

@canbekley that would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants