Repository navigation
dbt-core 1.10 support changes - #570
Merged
Merged
Conversation
koletzilla
marked this pull request as ready for review
November 26, 2025 11:59
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
koletzilla
commented
Nov 26, 2025
Comment on lines
-1
to
-4
| dbt-core>=1.9.0,<1.10 | ||
| dbt-core>=1.10.0,<1.11 | ||
| dbt-tests-adapter>=1.10,<2.0 | ||
| clickhouse-connect>=0.7.6 | ||
| clickhouse-driver>=0.2.7 |
Contributor
Author
There was a problem hiding this comment.
- clickhouse-connect and clickhouse-driver are already defined in setup.py
- dbt-core updated to 1.10 so test can run against it.
koletzilla
commented
Nov 26, 2025
| check_table_does_not_exist(project.adapter, "invalid") | ||
| check_table_does_not_exist(project.adapter, "skip") | ||
| assert "PASS=5 WARN=0 ERROR=1 SKIP=1 TOTAL=7" in output | ||
| assert "PASS=5 WARN=0 ERROR=1 SKIP=1 NO-OP=0 TOTAL=7" in output |
Contributor
Author
There was a problem hiding this comment.
Only this test "broke" after testing with 1.10 :D
BentsiLeviav
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #490
--sampleflag (docs) works. Add tests to cover the implementation.