Skip to content

allow using empty local_suffix - #569

Merged
koletzilla merged 1 commit into
ClickHouse:mainfrom
sergeykuprikov:main
Dec 11, 2025
Merged

koletzilla merged 1 commit into
ClickHouse:mainfrom
sergeykuprikov:main

Conversation

@sergeykuprikov

@sergeykuprikov sergeykuprikov commented Nov 12, 2025 •

Copy link
Copy Markdown
Contributor

Summary

Allow empty local_suffix in configuration

Remove restriction that required non-empty local_suffix values.
Users can now use empty string for simpler configuration setups.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@CLAassistant

CLAassistant commented Nov 12, 2025 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@windsurf-bot windsurf-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

@sergeykuprikov

Copy link
Copy Markdown
Contributor Author

/windsurf-review

@windsurf-bot windsurf-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

@koletzilla

Copy link
Copy Markdown
Contributor

Let's merge it! thanks!

@koletzilla
koletzilla merged commit 5e3684f into ClickHouse:main Dec 11, 2025
17 checks passed
@koletzilla koletzilla added this to the v.1.9.8 milestone Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants