Repository navigation
Improve codebase to reintegrate cloud tests ASAP. - #512
Merged
Merged
Conversation
koletzilla
force-pushed
the
fix-cloud-tests-v2
branch
from
September 12, 2025 08:15
80a6319 to
92f9202
Compare
koletzilla
force-pushed
the
fix-cloud-tests-v2
branch
from
September 18, 2025 09:40
eaeaea1 to
2b4e15a
Compare
koletzilla
force-pushed
the
fix-cloud-tests-v2
branch
from
September 30, 2025 14:12
2b4e15a to
f7d5d98
Compare
koletzilla
force-pushed
the
fix-cloud-tests-v2
branch
from
October 15, 2025 17:40
f7d5d98 to
769e2b4
Compare
koletzilla
force-pushed
the
fix-cloud-tests-v2
branch
from
November 21, 2025 11:24
d28a172 to
e5851b7
Compare
koletzilla
force-pushed
the
fix-cloud-tests-v2
branch
from
January 12, 2026 16:45
e5851b7 to
2541a15
Compare
koletzilla
commented
Jan 15, 2026
Comment on lines
+189
to
+192
| @pytest.mark.skipif( | ||
| os.environ.get('DBT_CH_TEST_CLOUD', '').lower() in ('1', 'true', 'yes'), | ||
| reason='Replicated is not supported for cloud', | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Those test were added in #575 but they fail in cloud. The issue is that they test Distributed tables and we cannot test them for cloud. They raise this error:
14:02:16 Compilation Error in model my_model_wrong_order (models/my_model_wrong_order.sql)
To use distributed materialization cluster setting in dbt profile must be set
> in macro materialization_distributed_table_clickhouse (macros/materializations/distributed_table.sql)
> called by model my_model_wrong_order (models/my_model_wrong_order.sql)Skipping them.
koletzilla
marked this pull request as ready for review
January 15, 2026 15:17
BentsiLeviav
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds back cloud tests so it will be executed on PRs again. I feel like they are now in a good enough shape to start executing them also in PRs. It also tests with the new CH Cloud cluster which is more stable than the other one.
Pending things:
Note
Re-enables Cloud testing in CI and makes tests compatible with Cloud limitations.
test_cloud.ymlto trigger on PRs tomainand set atimeout-minutes: 50forcloud_smt_tests.TestDistributed*ContractColumnsEqual) whenDBT_CH_TEST_CLOUDis true, since replicated tables aren’t supported in Cloud; addosimport to support skip logic.Written by Cursor Bugbot for commit 234d749. This will update automatically on new commits. Configure here.