Skip to content

fix(types): preserve JSON hints starting with SKIP - #485

Merged
abonander merged 2 commits into
ClickHouse:mainfrom
fallintoplace:fix/json-skip-prefixed-hints
Oct 7, 2026
Merged

fix(types): preserve JSON hints starting with SKIP#485
abonander merged 2 commits into
ClickHouse:mainfrom
fallintoplace:fix/json-skip-prefixed-hints

Conversation

@fallintoplace

@fallintoplace fallintoplace commented Oct 6, 2026

Copy link
Copy Markdown
Contributor
  • What: Keep JSON hints for paths like SKIPper.
  • Why: These names are treated as SKIP clauses, so inserts fail.
  • Implementation: Require a space after the SKIP keyword.

@abonander
abonander merged commit af76d45 into ClickHouse:main Oct 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonander abonander abonander approved these changes
@kavirajk kavirajk Awaiting requested review from kavirajk kavirajk is a code owner
@joe-clickhouse joe-clickhouse Awaiting requested review from joe-clickhouse joe-clickhouse is a code owner
@peter-leonov-ch peter-leonov-ch Awaiting requested review from peter-leonov-ch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fallintoplace @abonander