Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ClickHouseCommanddid not expose strongly typedExecuteReaderandExecuteReaderAsyncmethods.Calls on a
ClickHouseCommandinstance resolved to the inheritedDbCommandmethods, returningDbDataReaderandTask<DbDataReader>respectively.As a result, documented examples using
TryGetEnumOrdinaland otherClickHouseDataReader-specific members failed to compile without an explicit cast.This PR introduces typed
newoverloads forExecuteReaderandExecuteReaderAsync, following the existing API hiding pattern used byCreateParameter().The change allows consumers to access ClickHouse-specific reader functionality directly while preserving the standard ADO.NET behavior when commands are accessed through the
DbCommandabstraction.Fixes #690
Changes
ExecuteReaderandExecuteReaderAsyncoverloads toClickHouseCommand.PublicAPI.Unshipped.txtwith the new public API signatures.changelog.d/.DbCommandcompatibility.How to Test
ClickHouse.Driver.Teststest suite.ClickHouseCommand.ExecuteReaderAsync()exposesClickHouseDataReaderwithout requiring an explicit cast.TryGetEnumOrdinalare accessible directly.DbCommandcontinues to work as expected.