Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only changes consistently reflect the supplied server evidence and leave no unresolved findings.
No open issues 🎉
What changed in this PR
Clarifies the HTTP client’s documented URL limits for InsertQueryPlacement.Url, addressing #702 without changing runtime behavior or public signatures.
Changes:
- Documents the default 128 KiB limit on each URL-encoded parameter value.
- Distinguishes the separate 1 MiB whole-URI limit and explains that query-level settings cannot raise the parsing limit.
- Updates both public XML comments and adds a documentation changelog fragment.
| File | Description |
|---|---|
docs/http.mdx |
Clarifies URL query limits in the HTTP insert guide. |
ClickHouse.Driver/InsertQueryPlacement.cs |
Updates the Url enum value’s XML documentation. |
ClickHouse.Driver/InsertOptions.cs |
Aligns QueryPlacement XML documentation with the guide. |
changelog.d/702-url-query-limit.docs.md |
Records the documentation correction for #702. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #702.
http_max_field_value_size(128 KiB by default) to each URL parameter value, including the URL-encodedquerystatement.http_max_uri_size(1 MiB by default) as the separate whole-URI limit, and note that a query-level setting cannot raise the parsing limit.Verification
queryvalue of 131,072 bytes returned HTTP 200; 131,073 bytes returnedField value too long(HTTP 500). Sending the same SQL in the POST body succeeded.git diff --checkpassed.Checklist
No runtime behavior is changed.
Note
Low Risk
Documentation and XML comment updates only; no runtime or API behavior changes.
Overview
Documentation fix (#702) for
InsertQueryPlacement.Url: the docs now state that the URL-encodedquerystring is capped by ClickHouse’s per-parameter limithttp_max_field_value_size(128 KiB default), not only byhttp_max_uri_size(1 MiB whole URI) and the .NET ~65,519-character URI limit the driver already documents.The same clarification is applied in
InsertOptions,InsertQueryPlacement,docs/http.mdx, and a changelog fragment. No driver behavior changes—only accurate limits for operators choosing URL placement for binary inserts.Reviewed by Cursor Bugbot for commit f301c94. Bugbot is set up for automated code reviews on this repo. Configure here.