UI scene lifecycle support - #363
Conversation
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
reshab-code
changed the title
| + (instancetype)sharedInstance; | ||
|
|
||
| - (void)applicationDidLaunchWithOptions:(NSDictionary *)options; | ||
| - (void)sceneWillConnectWithOptions:(UISceneConnectionOptions *)connectionOptions API_AVAILABLE(ios(13.0)); |
There was a problem hiding this comment.
since we have another PR which moves these files to other folder, there will be merge conflict. @akashvercetti @reshab-code check order of PR merge for these 2 PRs or create a feature branch to be safe side before merging it to develop directly, as version bump PR also have one api changes
There was a problem hiding this comment.
yes a feature base branch will be needed for 4 PRs:
@reshab-code make a new feature branch with the word "4.2.0" in it and change the base branch of all 4 PRs.
I think your SPM PR should be merged last cuz u moved some files in another folder.
4 participants
@coderabbitai