SDK-6049: Fix per-page deep links for auto and manual carousel templates - #62
Open
reshab-code wants to merge 2 commits into
Open
SDK-6049: Fix per-page deep links for auto and manual carousel templates#62reshab-code wants to merge 2 commits into
reshab-code wants to merge 2 commits into
Conversation
BIS Accessibility Enhancements for iOS Push templates
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
nishant-clevertap
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In pt_carousel and pt_manual_carousel, tapping any page always opened pt_dl1 regardless of which page was visible. Two separate issues caused this.
CarouselProperties only declared pt_dl1, so the decoder silently dropped the other two links. A single actionUrl derived from pt_dl1 was then assigned to every carousel item at construction time.
Image validation calls are async. Results were appended to itemViews as they arrived, meaning the page at index 0 could end up being pt_img2 if it loaded faster than pt_img1, giving it the wrong deep link even if the links had been wired up correctly.
Changes