Magiclysm: universal mojocycle controls

[Kromgart]

Summary

Mods "Magiclysm: casters can always ride their mojocycles"

Purpose of change

Technomancer's conjured motorcycle is using standard vehicle controls, which have these flags:

Cataclysm-DDA/data/json/vehicleparts/vehicle_parts.json

Line 1215 in f564973

"flags": [ "CONTROLS", "NEED_LEG", "INOPERABLE_SMALL" ],

which are checked here:

Cataclysm-DDA/src/vehicle_use.cpp

Lines 690 to 704 in f564973

	if( has_part( player_character.pos_abs(), "NEED_LEG" ) &&
	player_character.get_working_leg_count() < 1 &&
	!has_part( player_character.pos_abs(), "IGNORE_LEG_REQUIREMENT" ) ) {
	add_msg( _( "You need at least one leg to control the %s." ), vp.name() );
	return false;
	}
	if( has_part( player_character.pos_abs(), "INOPERABLE_SMALL" ) &&
	( player_character.get_size() == creature_size::small ||
	player_character.get_size() == creature_size::tiny ) &&
	!has_part( player_character.pos_abs(), "IGNORE_HEIGHT_REQUIREMENT" ) ) {
	add_msg( _( "You are too short to reach the pedals!" ) );
	return false;
	}

Consequently it requires the vehicle user to be a "not-too-small" height and have at least 1 leg.

There are pedal_exdenders and hand_controls parts which can relax those requirements, but the Mojocycle is a summoned magical vehicle and you cannot interact/modify it.

Describe the solution

Added a controls_technomancer part: this is a copy of normal controls, but the restricting flags vere removed. Put this instead of the regular controls part in the mojocycle definition.

Describe alternatives you've considered

Feel the goblin suffering after he manages to cast the mojocycle for the first time.

I could instead just add pedal_extenders and hand_controls to the mojocycle, but it clutters the tile with more parts, puts more flags in use etc... Let the magic motorcycle do its magic things.

Testing

Loaded the game as a character with "Very Short" trait. Summoned the mojocycle. Can ride it now.

Additional context