Skip to content

[ Magiclysm ] khanjar for hy-brasilean guard - #88701

Open
Maleclypse wants to merge 11 commits into
CleverRaven:masterfrom
Maleclypse:Magiclysm-Khanjar-for-Hyborian-Guard
Open

Maleclypse wants to merge 11 commits into
CleverRaven:masterfrom
Maleclypse:Magiclysm-Khanjar-for-Hyborian-Guard

Conversation

@Maleclypse

Copy link
Copy Markdown
Member

Summary

None

Purpose of change

So while I was working on trimming the meaninglessly lighter and ineffectually more damaging plus one and two kitchen utensils, I noticed that the hy brasil honor guard had a plus one hunting knife. What a lame weapon for elite elvish soldiers. So I improved things with a unique weapon.

Describe the solution

Technique on crit weapon that casts a different spell depending on how much torso hp you have left.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions Bot added [JSON] Changes (can be) made in JSON Melee Melee weapons, tactics, techniques, reach attack Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Sep 17, 2026
@github-actions
github-actions Bot requested a review from KorGgenT September 17, 2026 05:06
@github-actions github-actions Bot added the astyled astyled PR, label is assigned by github actions label Sep 17, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot added the json-styled JSON lint passed, label assigned by github actions label Sep 17, 2026
Comment thread data/mods/Magiclysm/items/enchanted_melee.json Outdated
Co-authored-by: rty275 <788335+rty275@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Hy in string: "An ornate curved blade made of glassteel covered in intricate looping designs that refract light. These are the ceremonial daggers of the Hy-Brasil honor guard."
  • "Casts different spells on crit depending on user hp."
  • "Hy-Brasil Enchantment"
  • """Hy-Brasilian khanjar"""
  • """Hy-Brasilian khanjars"""

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions Bot removed the json-styled JSON lint passed, label assigned by github actions label Sep 17, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot added the json-styled JSON lint passed, label assigned by github actions label Sep 17, 2026
@Maleclypse Maleclypse changed the title [ Magiclysm ] khanjar for hyborian guard [ Magiclysm ] khanjar for hy-brasilean guard Sep 18, 2026
@github-actions github-actions Bot removed the json-styled JSON lint passed, label assigned by github actions label Sep 18, 2026
Comment thread data/mods/Magiclysm/effect_on_conditions/miscellaneous.json Outdated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot added the json-styled JSON lint passed, label assigned by github actions label Sep 18, 2026
Comment thread data/mods/Magiclysm/techniques.json Outdated
@github-actions github-actions Bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Melee Melee weapons, tactics, techniques, reach attack Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants