Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[DinoMod] Reattach sauropod legs"
Purpose of change
Realism, bugfix
Describe the solution
Assigns mtype correctly to all monster variants that use the new sauropod legs
Creates a new OR condition group for all of those same monster variants
Changes inheritance for small burned zombie sauropods and removes some duplication
Cleans up special attack for the biggest sauropods so that they spawn legs correctly and don't stomp with their faces
Cleans up special attacks for the smallest sauropods so they don't inherit giant comical legs
Describe alternatives you've considered
Also add support for the late game sauropod mutations but that's better handled in another PR IMO
Create a scorched zombie sauropod leg and EOC chain, probably the best approach but a bigger change than this bug fix is looking to do. At this time I don't think anything in the mod spawns adult scorched sauropod zombies so it's a pretty niche thing for players to see. There could be a burned stream variant special that spawned them.
Instead of duplicating EOC content for each monster species, figure out a complicated OR chain to check for each possible dino. Couldn't make that work with manual linting. Not sure if code was also bad.
Testing
Initial testing is not entirely encouraging. It looks like I missed some mtype_id groups in the first version of the special attacks update
(picture shows the character being mobbed by fast legs that have left their sad torso neck and tail far behind)
WIP
Additional context
Thanks again to Ifailatgaming on Discord for reporting that legs on some sauropods were running away comically