feat: let evaluate_script skip stable DOM wait#2344
Closed
mturac wants to merge 4 commits into
Closed
Conversation
Contributor
|
Heads-up: |
Contributor
Author
|
Thanks for the heads-up. I re-ran the generation path on the current head Validation: npm run gen
git diff --exit-code docs/tool-reference.md src/bin/chrome-devtools-cli-options.ts src/telemetry/tool_call_metrics.json
npm run check-format
npm run test:no-build -- tests/tools/script.test.tsAll pass locally. |
Collaborator
|
Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitForStableDomoption toevaluate_scriptso read-only scripts can skip the stable DOM waitFixes #2338
Testing
npm run typechecknpm run test -- tests/tools/script.test.tsnpm run check-formatgit diff --check