-
Notifications
You must be signed in to change notification settings - Fork 0
chore: sync plus with upstream main (conflicts) #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: plus
Are you sure you want to change the base?
Changes from all commits
23ad7f8
b2d7719
76ff70e
b7e167b
de1e506
9a0dafd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| { | ||
| "name": "@capacitor-plus/android", | ||
| "name": "@capacitor/android", | ||
| "version": "8.3.4", | ||
| "description": "Capacitor+: Enhanced Capacitor with automated upstream sync - Cross-platform apps with JavaScript and the web", | ||
| "homepage": "https://capgo.app/docs/plugins/capacitor-plus/", | ||
| "author": "Capgo Team <support@capgo.app> (https://capgo.app)", | ||
| "description": "Capacitor: Cross-platform apps with JavaScript and the web", | ||
| "homepage": "https://capacitorjs.com", | ||
| "author": "Ionic Team <hi@ionic.io> (https://ionic.io)", | ||
|
Comment on lines
+2
to
+6
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Verify whether both peers are currently mandatory and whether optional metadata exists.
jq '.name, .peerDependencies, .peerDependenciesMeta' android/package.json
# Check how widespread this dual-peer pattern is.
rg -n --iglob '**/package.json' '"@capacitor-plus/core"|peerDependenciesMeta'Repository: Cap-go/capacitor-plus Length of output: 281 🏁 Script executed: # Check for any documentation or comments explaining the dual-peer dependency
find . -name "README*" -o -name "CHANGELOG*" | head -5 | xargs -I {} sh -c 'echo "=== {} ===" && cat {} | head -30'Repository: Cap-go/capacitor-plus Length of output: 10129 🏁 Script executed: # Check git history or comments around the peerDependencies
git log --oneline -n 20 -- android/package.json 2>/dev/null || echo "Git history unavailable"Repository: Cap-go/capacitor-plus Length of output: 140 🏁 Script executed: # Search for any references or explanations about `@capacitor-plus/core` in the codebase
rg -i "capacitor-plus/core" --type md --type js --type ts -B2 -A2 | head -50Repository: Cap-go/capacitor-plus Length of output: 2830 Mark The dual peer dependency exists to support fallback compatibility (code tries Suggested fix "peerDependencies": {
"@capacitor-plus/core": "^8.3.0",
"@capacitor/core": "^8.3.0"
},
+ "peerDependenciesMeta": {
+ "@capacitor/core": {
+ "optional": true
+ }
+ },🤖 Prompt for AI Agents |
||
| "license": "MIT", | ||
| "repository": { | ||
| "type": "git", | ||
|
|
||
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert manual changelog edits and let CI regenerate.
This file was manually altered (including overlapping 8.3.x release content), but this repository treats
CHANGELOG.mdas CI/CD-managed output, so these edits should not be merged from this PR branch.As per coding guidelines, "Do not manually edit
CHANGELOG.md; it is managed automatically by CI/CD".🤖 Prompt for AI Agents