Skip to content

Add a compact text style selector to Content - #2601

Open
3mdistal wants to merge 4 commits into
mainfrom
codex/content-text-selector
Open

Add a compact text style selector to Content#2601
3mdistal wants to merge 4 commits into
mainfrom
codex/content-text-selector

Handle legacy heading styles in text selector

f8b6413
Select commit
Loading
Failed to load commit list.
Builder.io Integration / Review Agent completed Aug 4, 2026 in 15m 45s

Potential issues to review

Incremental Code Review Summary

The latest commit addresses the previous H5/H6 compatibility issue: the selector now detects all supported heading levels, shows H5/H6 in the trigger, converts them to Text, and intentionally keeps only Text/H1–H4 in the menu. The focused tests were expanded to cover H5/H6 conversion and a live paragraph-to-H5 transition. The change remains low risk overall because it is confined to Content editor UI, tests, changelog metadata, and visual evidence.

Key Findings

Medium: Escape dismissal suppresses Popover close autofocus unconditionally. When the focused menu closes via Escape, focus is not restored to the trigger or editor, so the bubble can disappear and the user must click back into the document before continuing.

Medium: A mixed selection spanning a paragraph and heading is classified as paragraph by editor.isActive, so selecting Text takes the no-op path and leaves any selected heading blocks unchanged. Text should apply paragraph conversion unconditionally to the selected blocks.

The H5/H6 repair itself is sound, and the pointer/keyboard selection logic and accessibility roles remain consistent with the intended design. Browser verification was attempted against the healthy dev server, but all executor retries lacked browser interaction tools.

🧪 Browser testing: Skipped — browser executor tooling was unavailable after retries; all planned cases were reported as unable to verify.