-
Notifications
You must be signed in to change notification settings - Fork 423
Use one workspace sign-in across Agent Native Desktop apps #2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
3mdistal
wants to merge
36
commits into
main
Choose a base branch
from
codex/desktop-workspace-sso
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
58dab88
Add Desktop workspace single sign-on
3mdistal 32e425f
Prepare Desktop SSO canary deployment
3mdistal 2c7abf4
Sync workspace authentication skill
3mdistal 15f48a8
Fix Desktop workspace sign-out races
3mdistal 165f0c3
Merge remote-tracking branch 'origin/main' into codex/desktop-workspa…
3mdistal 8d33fff
Preserve Desktop workspace logout semantics
3mdistal 555b91f
Pin Desktop SSO canary during acceptance
3mdistal d2a3919
Correct Desktop SSO work evidence state
3mdistal 3f623cf
Stabilize A2A deadline test under load
3mdistal 0ab3d3b
Use main A2A deadline stabilization
3mdistal 7d4cbf4
Merge remote-tracking branch 'origin/main' into codex/desktop-workspa…
3mdistal 3d380f5
Refresh Desktop SSO integration evidence
3mdistal 0dacfbe
Record exact-head canary readiness
3mdistal 49fd377
fix(desktop): forward webview navigation URLs
3mdistal 5d57687
fix(desktop): handle main-frame webview navigation
3mdistal d19c92f
fix(desktop): resolve identity redirects with net request
3mdistal 33be7c1
docs: record desktop SSO canary acceptance
3mdistal 652fc57
fix(desktop): sign in through identity authority
3mdistal aeeb061
docs: record direct desktop authority sign-in
3mdistal 20f6a6e
docs: sync workspace authentication skill
3mdistal 216f4a0
fix(desktop): use app sign-in as workspace front door
3mdistal c737f83
docs(auth): sync workspace authentication guidance
3mdistal 6e202d7
Merge remote-tracking branch 'origin/main' into codex/desktop-workspa…
3mdistal 302e992
docs(auth): refresh desktop SSO work evidence
3mdistal 7535935
fix(desktop): isolate SSO canary profile
3mdistal fdc6da0
fix(desktop): wait for federated session cookie
3mdistal baf8115
Require committed Desktop SSO completion
3mdistal 6426bca
Record Desktop SSO verification receipt
3mdistal d6607b4
Bound Desktop quit cleanup
3mdistal 579d5f5
Keep shell modals above Desktop webviews
3mdistal cff2f0a
Remove modal webviews from native layout
3mdistal 57d30f6
Enable Google sign-in on hosted Dispatch
3mdistal 2506adc
Format Dispatch changelog entry
3mdistal f1820d7
Gate hosted Dispatch Google auth by deploy context
3mdistal 66f0221
Merge remote-tracking branch 'origin/main' into codex/desktop-workspa…
3mdistal af0c143
Merge remote-tracking branch 'origin/main' into codex/desktop-workspa…
3mdistal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| "@agent-native/core": minor | ||
| "@agent-native/dispatch": patch | ||
| --- | ||
|
|
||
| Add an authenticated, nonce-only completion route for packaged Desktop clients orchestrating cross-app identity federation. | ||
|
|
||
| Ensure Dispatch installs identity federation routes on its primary auth guard so concurrent Nitro plugin startup cannot pre-empt them with a 401. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| name: Desktop SSO Canary | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - codex/desktop-workspace-sso | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| build-signed-macos-canary: | ||
| if: github.ref == 'refs/heads/codex/desktop-workspace-sso' | ||
| runs-on: macos-latest | ||
| timeout-minutes: 60 | ||
| steps: | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1 | ||
|
|
||
| - uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0 | ||
|
|
||
| - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
| node-version: 22 | ||
| cache: pnpm | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile | ||
|
|
||
| - name: Set canary version | ||
| working-directory: packages/desktop-app | ||
| env: | ||
| CANARY_SUFFIX: ${{ github.run_number }} | ||
| run: | | ||
| BASE=$(node -p "require('./package.json').version") | ||
| npm version "${BASE}-desktop-sso-canary.${CANARY_SUFFIX}" --no-git-tag-version | ||
|
|
||
| - name: Import signing certificate | ||
| env: | ||
| APPLE_CERTIFICATE: ${{ secrets.APPLE_CERTIFICATE }} | ||
| APPLE_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }} | ||
| run: | | ||
| set -euo pipefail | ||
| CERTIFICATE_PATH="$RUNNER_TEMP/desktop-canary-certificate.p12" | ||
| KEYCHAIN_PATH="$RUNNER_TEMP/desktop-canary.keychain-db" | ||
| echo "$APPLE_CERTIFICATE" | base64 --decode > "$CERTIFICATE_PATH" | ||
| security create-keychain -p "" "$KEYCHAIN_PATH" | ||
| security default-keychain -s "$KEYCHAIN_PATH" | ||
| security unlock-keychain -p "" "$KEYCHAIN_PATH" | ||
| security import "$CERTIFICATE_PATH" -k "$KEYCHAIN_PATH" -P "$APPLE_CERTIFICATE_PASSWORD" -T /usr/bin/codesign | ||
| security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "" "$KEYCHAIN_PATH" | ||
| rm "$CERTIFICATE_PATH" | ||
|
|
||
| - name: Build signed and notarized canary | ||
| working-directory: packages/desktop-app | ||
| env: | ||
| APPLE_ID: ${{ secrets.APPLE_ID }} | ||
| APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }} | ||
| APPLE_TEAM_ID: W3PMF2T3MW | ||
| SENTRY_DESKTOP_DSN: ${{ secrets.SENTRY_DESKTOP_DSN || secrets.SENTRY_ELECTRON_DSN || secrets.SENTRY_CLIENT_DSN || secrets.SENTRY_DSN }} | ||
| SENTRY_DESKTOP_CLIENT_KEY: ${{ secrets.SENTRY_DESKTOP_CLIENT_KEY || secrets.SENTRY_CLIENT_KEY }} | ||
| SENTRY_DESKTOP_PROJECT_ID: ${{ secrets.SENTRY_DESKTOP_PROJECT_ID || secrets.SENTRY_PROJECT_ID }} | ||
| SENTRY_DESKTOP_INGEST_HOST: ${{ secrets.SENTRY_DESKTOP_INGEST_HOST || secrets.SENTRY_INGEST_HOST }} | ||
| SENTRY_DESKTOP_ENVIRONMENT: canary | ||
| run: pnpm build && npx electron-builder --mac --config --publish never | ||
|
|
||
| - name: Verify candidate provenance and trust | ||
| working-directory: packages/desktop-app | ||
| env: | ||
| EXPECTED_COMMIT: ${{ github.sha }} | ||
| run: | | ||
| set -euo pipefail | ||
| test "$(git rev-parse HEAD)" = "$EXPECTED_COMMIT" | ||
| VERSION=$(node -p "require('./package.json').version") | ||
| test -n "$VERSION" | ||
|
|
||
| APP_COUNT=0 | ||
| while IFS= read -r -d '' APP_PATH; do | ||
| APP_COUNT=$((APP_COUNT + 1)) | ||
| INFO="$APP_PATH/Contents/Info.plist" | ||
| codesign --verify --deep --strict --verbose=2 "$APP_PATH" | ||
| xcrun stapler validate "$APP_PATH" | ||
| spctl --assess --type execute --verbose=4 "$APP_PATH" | ||
| /usr/libexec/PlistBuddy -c "Print :CFBundleIdentifier" "$INFO" | grep -qx 'com.agentnative.desktop' | ||
| /usr/libexec/PlistBuddy -c "Print :CFBundleShortVersionString" "$INFO" | grep -Fqx "$VERSION" | ||
| done < <(find dist -type d -name 'Agent Native.app' -print0) | ||
| test "$APP_COUNT" -eq 2 | ||
|
|
||
| { | ||
| echo "workflow_run=${GITHUB_RUN_ID}" | ||
| echo "commit=${EXPECTED_COMMIT}" | ||
| echo "version=${VERSION}" | ||
| echo "bundle_id=com.agentnative.desktop" | ||
| } > dist/CANARY-MANIFEST.txt | ||
| find dist -maxdepth 1 -type f \( -name '*.dmg' -o -name '*.zip' \) -print0 \ | ||
| | sort -z \ | ||
| | xargs -0 shasum -a 256 >> dist/CANARY-MANIFEST.txt | ||
| grep -q '\.dmg$' < <(find dist -maxdepth 1 -type f -name '*.dmg') | ||
| grep -q '\.zip$' < <(find dist -maxdepth 1 -type f -name '*.zip') | ||
|
|
||
| - name: Upload short-lived canary artifact | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| name: desktop-sso-canary-${{ github.sha }} | ||
| path: | | ||
| packages/desktop-app/dist/*.dmg | ||
| packages/desktop-app/dist/*.zip | ||
| packages/desktop-app/dist/CANARY-MANIFEST.txt | ||
| if-no-files-found: error | ||
| retention-days: 3 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.